launchpad-reviewers team mailing list archive

[Free Ekanayaka <free.ekanayaka@xxxxxxxxxxxxx>]

The proposal to merge lp:~free.ekanayaka/txlongpoll/queue-manager-into-own-module into lp:txlongpoll has been updated.

Description changed to:

Move QueueManager into its own modude. There's no change in the logic, and it's a move towards deprecating a few APIs of QueueManager (in particular QueueManager.connected/QueueManager.disconnected) in order to be able to leverage the new ClientService from Twisted 16. The new class will be called NotificationSource and QueueManager will become a subclass of it, with some small backward-compatibility code.

The branch also moves existing QueueManager tests into a new txlongpoll/tests/test_integration.py file, since they are really integration tests using a real broker. I'll add unit tests in a separate branch.

For more details, see:
https://code.launchpad.net/~free.ekanayaka/txlongpoll/queue-manager-into-own-module/+merge/296791
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~free.ekanayaka/txlongpoll/queue-manager-into-own-module into lp:txlongpoll.