← Back to team overview

launchpad-reviewers team mailing list archive

Re: [Merge] lp:~thomir/launchpad/devel-fix-git-links into lp:launchpad

 

> I'm happy with most of this now, but there is one oddity.  Revision 18107 in
> your branch seems to have partially reverted some previous fixes you applied
> in response to my previous review feedback, so e.g. it still has the dubious
> check for '+git' as a path substring.  Was there a particular reason for that,
> or was it an accident? 

Ugh - that was an accident. Reverting now.

-- 
https://code.launchpad.net/~thomir/launchpad/devel-fix-git-links/+merge/297963
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References