← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~cjwatson/launchpad/revision-header into lp:launchpad

 

The proposal to merge lp:~cjwatson/launchpad/revision-header into lp:launchpad has been updated.

Description changed to:

Publish Launchpad's code revision in an X-Launchpad-Revision header.

This means that lp-devops-dashboard will no longer need to do this kind of thing to scrape out the revno, and can just do a simple HEAD request instead:

            lp_version_comment = soup.find(
                text=re.compile("external actions issued in"))
            revision_re = re.compile(r'r(\d+)')
            matches = revision_re.search(lp_version_comment)
            if matches:
                self.last_deployed_revno = int(matches.group(1))

Once we move to git, the value can switch to being the commit ID.

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/revision-header/+merge/298124
-- 
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.


References