launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Review: Approve

Mostly fine now, but the CSS is awfully specific.  Could you please make it be controlled by a new CSS class instead of [name="field.processors"]?  You can then arrange to set that class like this in SnapAddView:

    def setUpWidgets(self):
        """See `LaunchpadFormView`."""
        super(SnapAddView, self).setUpWidgets()
        self.widgets['processors'].widget_class = 'your-class-name'
-- 
https://code.launchpad.net/~maxiberta/launchpad/new-snap-select-processors/+merge/298242
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.