launchpad-reviewers team mailing list archive

[Kit Randel <kit.randel@xxxxxxxxxxxxx>]

The proposal to merge lp:~blr/rutabaga/auth-helper-no-exit into lp:rutabaga has been updated.

Description changed to:

I noticed on Dogfood that squid complained of rutabaga's auth helper exiting unexpectedly.

e.g.

2016/07/11 02:50:44.703| helper.cc(1180) GetFirstAvailable: GetFirstAvailable: Running servers 1
2016/07/11 02:50:44.733| helper.cc(901) helperHandleRead: helperHandleRead: 0 bytes from basicauthenticator #1
2016/07/11 02:50:44.733| WARNING: basicauthenticator #1 exited

This is not particularly well documented, but I think the expectation is that the helper should not exit, unless under exceptional circumstances. I've confirmed this by looking at examples of other auth helpers, none of which are authoritative unfortunately.

I have tested this change on Dogfood however, and the error is no longer present and all appears well.

This could have potentially been contributing to the intermittent failures we've been seeing (unrelated to the maven issues), but have no evidence of that being the case.

For more details, see:
https://code.launchpad.net/~blr/rutabaga/auth-helper-no-exit/+merge/299638
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~blr/rutabaga/auth-helper-no-exit into lp:rutabaga.