launchpad-reviewers team mailing list archive

[Thomi Richards <thomi.richards@xxxxxxxxxxxxx>]

Review: Approve

LGTM - one minor comment you should feel free to ignore.

Diff comments:

> === added file 'database/schema/patch-2209-69-5.sql'
> --- database/schema/patch-2209-69-5.sql	1970-01-01 00:00:00 +0000
> +++ database/schema/patch-2209-69-5.sql	2016-06-30 16:10:32 +0000
> @@ -0,0 +1,10 @@
> +-- Copyright 2016 Canonical Ltd.  This software is licensed under the
> +-- GNU Affero General Public License version 3 (see the file LICENSE).
> +
> +SET client_min_messages=ERROR;
> +
> +ALTER TABLE Snap ADD COLUMN store_channels text;
> +
> +COMMENT ON COLUMN Snap.store_channels IS 'Channels to which to release this snap package after uploading it to the store.';

A minor nit-pick, but the sentence construction here seems a little awkward - what about:

COMMENT ON COLUMN Snap.store_channels IS 'Channels to release this snap package to after uploading it to the store.';

> +
> +INSERT INTO LaunchpadDatabaseRevision VALUES (2209, 69, 5);


-- 
https://code.launchpad.net/~cjwatson/launchpad/db-snap-channels/+merge/298803
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/db-snap-channels into lp:launchpad/db-devel.