launchpad-reviewers team mailing list archive

[Kit Randel <kit.randel@xxxxxxxxxxxxx>]

Kit Randel has proposed merging lp:~blr/rutabaga/fix-squid-helper-timeout into lp:rutabaga.

Commit message:
ERR should be written to stdout.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~blr/rutabaga/fix-squid-helper-timeout/+merge/300037

The recent refactoring in r61 surfaced this issue, as the helper has never in fact handled the error state correctly. Before, without an explicit 'OK' and an exit, squid rightly responded with a 407, which gave the false impression that squid was responding to 'ERR'. 
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~blr/rutabaga/fix-squid-helper-timeout into lp:rutabaga.

=== modified file 'rutabaga/scripts/rutabaga_auth_helper.py'
--- rutabaga/scripts/rutabaga_auth_helper.py	2016-07-11 03:07:30 +0000
+++ rutabaga/scripts/rutabaga_auth_helper.py	2016-07-14 05:14:30 +0000
@@ -53,7 +53,7 @@
         if validate(username, secret):
             sys.stdout.write('OK\n')
         else:
-            sys.stderr.write('ERR\n')
+            sys.stdout.write('ERR\n')
         sys.stdout.flush()