launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/schedule-bug-watches-frequently into lp:launchpad.

Commit message:
Run BugWatchScheduler from garbo-frequently rather than garbo-hourly, for the sake of new watches.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/schedule-bug-watches-frequently/+merge/300195

When you create a new bug watch, it can take up to an hour for Launchpad to get round to running BugWatchScheduler so that checkwatches will check the remote bug.  This seems a pretty excessive delay for something you might well be waiting for in order to make sure that it worked.  BugWatchScheduler typically only takes a second or two to run, so it should be fine to run it more frequently.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/schedule-bug-watches-frequently into lp:launchpad.

=== modified file 'lib/lp/scripts/garbo.py'
--- lib/lp/scripts/garbo.py	2016-06-14 14:25:24 +0000
+++ lib/lp/scripts/garbo.py	2016-07-15 14:22:58 +0000
@@ -1781,6 +1781,7 @@
     tunable_loops = [
         AntiqueSessionPruner,
         BugSummaryJournalRollup,
+        BugWatchScheduler,
         OpenIDConsumerAssociationPruner,
         OpenIDConsumerNoncePruner,
         PopulateDistributionSourcePackageCache,
@@ -1803,7 +1804,6 @@
     script_name = 'garbo-hourly'
     tunable_loops = [
         BugHeatUpdater,
-        BugWatchScheduler,
         DuplicateSessionPruner,
         RevisionCachePruner,
         UnusedSessionPruner,