launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/snap-edit-channels-formatting into lp:launchpad.

Commit message:
Fix indentation of channels widget on Snap:+edit.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/snap-edit-channels-formatting/+merge/301375

Fix indentation of channels widget on Snap:+edit to match how it appears on {Branch,GitRef}:+new-snap.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/snap-edit-channels-formatting into lp:launchpad.

=== modified file 'lib/lp/snappy/templates/snap-edit.pt'
--- lib/lp/snappy/templates/snap-edit.pt	2016-06-30 17:15:26 +0000
+++ lib/lp/snappy/templates/snap-edit.pt	2016-07-28 12:48:33 +0000
@@ -86,11 +86,11 @@
                 <tal:widget define="widget nocall:view/widgets/store_name">
                   <metal:block use-macro="context/@@launchpad_form/widget_row" />
                 </tal:widget>
+                <tal:widget define="widget nocall:view/widgets/store_channels"
+                            condition="widget/context/value_type/vocabulary">
+                  <metal:block use-macro="context/@@launchpad_form/widget_row" />
+                </tal:widget>
               </table>
-              <tal:widget define="widget nocall:view/widgets/store_channels"
-                          condition="widget/context/value_type/vocabulary">
-                <metal:block use-macro="context/@@launchpad_form/widget_row" />
-              </tal:widget>
               <p class="formHelp">
                 If you change any settings related to automatically uploading
                 builds of this snap to the store, then the login service will