← Back to team overview

launchpad-reviewers team mailing list archive

Thread
Date

Re: [Merge] lp:~apw/launchpad/signing-key-generate-subject-limit into lp:launchpad

To: Colin Watson <cjwatson@xxxxxxxxxxxxx>
From: Andy Whitcroft <apw@xxxxxxxxxxxxx>
Date: Wed, 10 Aug 2016 09:26:59 -0000
In-reply-to: <20160809073604.17026.7837.codereview@chaenomeles.canonical.com>
Reply-to: mp+301642@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

> Looks good, but any chance of a test for the truncation case?

Sounds reasonable indeed.  For this purpose I have pulled out the common name generation to a shiny new helper.  This I have added a range of tests for.
-- 
https://code.launchpad.net/~apw/launchpad/signing-key-generate-subject-limit/+merge/301642
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

References

Re: [Merge] lp:~apw/launchpad/signing-key-generate-subject-limit into lp:launchpad
From: Colin Watson, 2016-08-09