launchpad-reviewers team mailing list archive

[Paul Collins <paul.collins@xxxxxxxxxxxxx>]

Review: Disapprove

See below; private Git repositories must be cloned via ssh.

Diff comments:

> === modified file 'lp/mojo-lp-snap-proxy/collect-payload'
> --- lp/mojo-lp-snap-proxy/collect-payload	2015-11-19 03:31:43 +0000
> +++ lp/mojo-lp-snap-proxy/collect-payload	2016-07-25 04:36:52 +0000
> @@ -1,3 +1,3 @@
> -rutabaga-code-tip          lp:rutabaga
> -rutabaga-dependencies      lp:~canonical-launchpad-branches/rutabaga/dependencies
> +rutabaga-code-tip          git+https://git.launchpad.net/rutabaga

This is a private repository, and so must (currently?) be cloned via git+ssh.

> +rutabaga-dependencies      git+https://git.launchpad.net/~canonical-launchpad-branches/rutabaga/+git/dependencies
>  


-- 
https://code.launchpad.net/~blr/canonical-mojo-specs/snap-proxy-git/+merge/301032
Your team Launchpad code reviewers is subscribed to branch lp:~canonical-launchpad-branches/canonical-mojo-specs/trunk.