launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing code

I don't think we can sensibly do this on creation. It's a potentially slow operation, can't just be skipped if it takes too long (unlike eg. showing recent commits on the MP page), and can easily be deferred to something like UpdatePreviewDiffJob (maybe even UpdatePreviewDiffJob itself). It would also avoid unnecessarily complicating every test that touches MPs, and minimise the risk that a tip change event entirely fails.
-- 
https://code.launchpad.net/~cjwatson/launchpad/fix-git-update-related-bugs/+merge/304941
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.