launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/git-update-related-bugs-with-structsubs into lp:launchpad.

Commit message:
Grant merge-proposal-jobs access to tables needed to handle structural subscriptions.

Requested reviews:
  Colin Watson (cjwatson)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/git-update-related-bugs-with-structsubs/+merge/305161

Grant merge-proposal-jobs access to tables needed to handle structural subscriptions.  Glitch noticed while testing on qastaging.
-- 
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== modified file 'database/schema/security.cfg'
--- database/schema/security.cfg	2016-09-06 15:34:38 +0000
+++ database/schema/security.cfg	2016-09-08 02:11:23 +0000
@@ -1987,6 +1987,12 @@
 public.bugnotificationfilter            = SELECT, INSERT
 public.bugnotificationrecipient         = SELECT, INSERT
 public.bugsubscription                  = SELECT
+public.bugsubscriptionfilter            = SELECT
+public.bugsubscriptionfilterinformationtype = SELECT
+public.bugsubscriptionfilterimportance  = SELECT
+public.bugsubscriptionfilterstatus      = SELECT
+public.bugsubscriptionfiltertag         = SELECT
+public.bugtag                           = SELECT
 public.bugtask                          = SELECT
 public.bugtaskflat                      = SELECT
 public.bugwatch                         = SELECT

=== modified file 'lib/lp/code/model/tests/test_branchmergeproposaljobs.py'
--- lib/lp/code/model/tests/test_branchmergeproposaljobs.py	2016-09-07 11:12:58 +0000
+++ lib/lp/code/model/tests/test_branchmergeproposaljobs.py	2016-09-08 02:11:23 +0000
@@ -265,6 +265,10 @@
     def test_run_git_updates_related_bugs(self):
         # The merge proposal has its related bugs updated.
         bug = self.factory.makeBug()
+        # Create a structural subscription to ensure we don't short-circuit
+        # in _get_structural_subscription_filter_id_query.
+        subscriber = self.factory.makePerson()
+        bug.default_bugtask.target.addSubscription(subscriber, subscriber)
         bmp, _, _, patch = self.createExampleGitMerge()
         self.hosting_fixture.getLog.result = [
             {