launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> 
> === modified file 'lib/lp/code/browser/widgets/tests/test_gitrepositorytargetwidget.py'
> --- lib/lp/code/browser/widgets/tests/test_gitrepositorytargetwidget.py	2016-06-17 15:46:57 +0000
> +++ lib/lp/code/browser/widgets/tests/test_gitrepositorytargetwidget.py	2016-09-08 02:59:42 +0000
> @@ -107,6 +109,15 @@
>          self.assertIsNone(getattr(self.widget, "package_widget", None))
>          self.assertIsNone(getattr(self.widget, "project_widget", None))
>  
> +    def test_setUpSubWidgets_dsp_picker_feature_flag(self):
> +        # The DistributionSourcePackageVocabulary is used when the
> +        # disclosure.dsp_picker.enabled is true.
> +        with FeatureFixture({u"disclosure.dsp_picker.enabled": u"on"}):
> +            self.widget.setUpSubWidgets()
> +        self.assertIsInstance(
> +            self.widget.package_widget.context.vocabulary,
> +            DistributionSourcePackageVocabulary)

Should this also check that the distribution context is correctly inferred?

> +
>      def test_setUpOptions_default_project_checked(self):
>          # The radio button options are composed of the setup widgets with
>          # the project widget set as the default.


-- 
https://code.launchpad.net/~cjwatson/launchpad/git-repository-target-widget-dsp-vocab/+merge/305162
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.