launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> 
> === modified file 'lib/lp/services/job/tests/__init__.py'
> --- lib/lp/services/job/tests/__init__.py	2015-10-12 13:16:54 +0000
> +++ lib/lp/services/job/tests/__init__.py	2016-10-05 14:11:35 +0000
> @@ -39,7 +40,15 @@
>          '--queues', queue,
>          '--include', 'lp.services.job.tests.celery_helpers',
>      )
> -    return running('bin/celery', cmd_args, cwd=cwd)
> +    with open('/dev/null', 'w') as devnull:
> +        proc = subprocess.Popen(
> +            ('bin/celery',) + cmd_args, stdout=devnull,
> +            stderr=subprocess.PIPE, cwd=cwd)
> +        try:
> +            yield proc
> +        finally:
> +            proc.terminate()
> +            proc.wait()

The duplication could probably be commented.

>  
>  
>  @contextmanager


-- 
https://code.launchpad.net/~cjwatson/launchpad/quieter-test-output/+merge/307721
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.