launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging ~cjwatson/turnip:tests-set-user-name into turnip:master.

Commit message:
tests: Set user.name as well as user.email

Without this, in at least some configurations, git complains:

  fatal: empty ident name (for <test@xxxxxxxxxxx>) not allowed

... and tests fail.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/turnip/+git/turnip/+merge/307826

Set user.name as well as user.email in tests.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of ~cjwatson/turnip:tests-set-user-name into turnip:master.

diff --git a/turnip/pack/tests/test_functional.py b/turnip/pack/tests/test_functional.py
index 07fc511..9ded8ff 100644
--- a/turnip/pack/tests/test_functional.py
+++ b/turnip/pack/tests/test_functional.py
@@ -166,6 +166,8 @@ class FunctionalTestMixin(object):
         # Clone the empty repo from the backend and commit to it.
         yield self.assertCommandSuccess((b'git', b'clone', self.url, clone1))
         yield self.assertCommandSuccess(
+            (b'git', b'config', b'user.name', b'Test User'), path=clone1)
+        yield self.assertCommandSuccess(
             (b'git', b'config', b'user.email', b'test@xxxxxxxxxxx'),
             path=clone1)
         yield self.assertCommandSuccess(
@@ -193,6 +195,8 @@ class FunctionalTestMixin(object):
 
         # Commit and push from the second clone.
         yield self.assertCommandSuccess(
+            (b'git', b'config', b'user.name', b'Test User'), path=clone2)
+        yield self.assertCommandSuccess(
             (b'git', b'config', b'user.email', b'test@xxxxxxxxxxx'),
             path=clone2)
         yield self.assertCommandSuccess(
@@ -217,6 +221,8 @@ class FunctionalTestMixin(object):
         # Push a commit that we can try to clone.
         yield self.assertCommandSuccess((b'git', b'clone', self.url, clone1))
         yield self.assertCommandSuccess(
+            (b'git', b'config', b'user.name', b'Test User'), path=clone1)
+        yield self.assertCommandSuccess(
             (b'git', b'config', b'user.email', b'test@xxxxxxxxxxx'),
             path=clone1)
         yield self.assertCommandSuccess(
@@ -312,6 +318,8 @@ class FrontendFunctionalTestMixin(FunctionalTestMixin):
         yield self.assertCommandSuccess(
             (b'git', b'clone', self.ro_url, clone1))
         yield self.assertCommandSuccess(
+            (b'git', b'config', b'user.name', b'Test User'), path=clone1)
+        yield self.assertCommandSuccess(
             (b'git', b'config', b'user.email', b'test@xxxxxxxxxxx'),
             path=clone1)
         yield self.assertCommandSuccess(