launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> 
> === modified file 'lib/lp/code/interfaces/hasbranches.py'
> --- lib/lp/code/interfaces/hasbranches.py	2016-09-07 02:46:20 +0000
> +++ lib/lp/code/interfaces/hasbranches.py	2016-10-14 16:44:55 +0000
> @@ -170,19 +174,31 @@
>      @call_with(registrant=REQUEST_USER)
>      @export_factory_operation(Interface, [])  # Really ICodeImport.
>      @operation_for_version('beta')
> -    def newCodeImport(registrant=None, branch_name=None, rcs_type=None,
> -                      url=None, cvs_root=None, cvs_module=None, owner=None):
> +    def newCodeImport(registrant=None, branch_name=None,
> +                      rcs_type=None, target_rcs_type=None, url=None,
> +                      cvs_root=None, cvs_module=None, owner=None):
>          """Create a new code import.
>  
>          :param registrant: The IPerson to record as the registrant of the
> -            import
> -        :param branch_name: The name of the branch to create.
> +            import.
> +        :param branch_name: The name of the branch or repository to create.
>          :param rcs_type: The type of the foreign VCS.
> +        :param target_rcs_type: The type of the branch or repository to
> +            create (Bazaar or Git).
>          :param url: The URL to import from if the VCS type uses a single URL
>              (i.e. isn't CVS).
>          :param cvs_root: The CVSROOT for a CVS import.
>          :param cvs_module: The module to import for a CVS import.
> -        :param owner: Who should own the created branch, or None for it to
> -            be the same as the registrant, or the caller over the API.
> +        :param owner: Who should own the created branch or repository, or
> +            None for it to be the same as the registrant, or the caller over
> +            the API.
>          :returns: An instance of `ICodeImport`.
>          """
> +
> +
> +class IHasCodeImportsToBazaar(IHasCodeImports):
> +    """Marker interface for targets that support code imports to Bazaar."""
> +
> +
> +class IHasCodeImportsToGit(IHasCodeImports):
> +    """Marker interface for targets that support code imports to Git."""

Are these markers pulling their weight over just checking for IHasCodeImports and IHasBranches/IHasGitRepositories?



-- 
https://code.launchpad.net/~cjwatson/launchpad/codeimport-git-webservice/+merge/308399
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.