launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> 
> === modified file 'lib/lp/snappy/model/snap.py'
> --- lib/lp/snappy/model/snap.py	2016-12-15 19:54:46 +0000
> +++ lib/lp/snappy/model/snap.py	2017-01-04 21:19:31 +0000
> @@ -346,6 +346,14 @@
>          self.distro_series = value.distro_series
>          self.store_series = value.snappy_series
>  
> +    @property
> +    def store_channels(self):
> +        return [] if self._store_channels is None else self._store_channels

"self._store_channels or []"?

> +
> +    @store_channels.setter
> +    def store_channels(self, value):
> +        self._store_channels = value if value else None

"value or None"?

> +
>      @staticmethod
>      def extractSSOCaveat(macaroon):
>          locations = [


-- 
https://code.launchpad.net/~cjwatson/launchpad/snap-export-store-channels/+merge/314116
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.