launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/isolate-launchpadlib-tests into lp:launchpad.

Commit message:
Stop the launchpadlib pagetests from writing to $HOME, and upgrade to launchpadlib 1.10.5 for better doctest isolation.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/isolate-launchpadlib-tests/+merge/316083

This relies on https://code.launchpad.net/~cjwatson/launchpadlib/isolate-doctests/+merge/316081.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/isolate-launchpadlib-tests into lp:launchpad.

=== modified file 'lib/lp/services/webservice/stories/launchpadlib.txt'
--- lib/lp/services/webservice/stories/launchpadlib.txt	2016-01-26 15:14:01 +0000
+++ lib/lp/services/webservice/stories/launchpadlib.txt	2017-02-01 09:48:35 +0000
@@ -5,6 +5,15 @@
 As an alternative to crafting HTTP requests with the 'webservice'
 object, you can write pagetests using launchpadlib.
 
+    >>> from fixtures import (
+    ...     EnvironmentVariable,
+    ...     TempDir,
+    ...     )
+    >>> tempdir_fixture = TempDir()
+    >>> tempdir_fixture.setUp()
+    >>> home_fixture = EnvironmentVariable('HOME', tempdir_fixture.path)
+    >>> home_fixture.setUp()
+
 Two helper functions make it easy to set up Launchpad objects that
 can access the web service. With launchpadlib_for() you can set up a
 Launchpad object for a given user with a single call.
@@ -147,3 +156,6 @@
     >>> import zope.testing.cleanup
     >>> zope.testing.cleanup._cleanups
     [...(<function _clean_up_cache...>, ('/.../launchpadlib-cache-...'...)...]
+
+    >>> home_fixture.cleanUp()
+    >>> tempdir_fixture.cleanUp()

=== modified file 'versions.cfg'
--- versions.cfg	2016-11-03 15:19:01 +0000
+++ versions.cfg	2017-02-01 09:48:35 +0000
@@ -51,7 +51,7 @@
 keyring = 0.6.2
 kombu = 3.0.30
 launchpad-buildd = 136
-launchpadlib = 1.10.4
+launchpadlib = 1.10.5
 lazr.authentication = 0.1.1
 lazr.batchnavigator = 1.2.11
 lazr.config = 1.1.3