← Back to team overview

launchpad-reviewers team mailing list archive

[Merge] lp:~wgrant/launchpad/privacy-skip-codereviewvote-reviewer into lp:launchpad

 

William Grant has proposed merging lp:~wgrant/launchpad/privacy-skip-codereviewvote-reviewer into lp:launchpad.

Commit message:
Allow team privacy changes when referenced by CodeReviewVote.reviewer.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~wgrant/launchpad/privacy-skip-codereviewvote-reviewer/+merge/320142

Allow team privacy changes when referenced by CodeReviewVote.reviewer.

Such references occur often when a team is configured as a branch's
default reviewer.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~wgrant/launchpad/privacy-skip-codereviewvote-reviewer into lp:launchpad.
=== modified file 'lib/lp/registry/model/person.py'
--- lib/lp/registry/model/person.py	2017-01-11 18:45:55 +0000
+++ lib/lp/registry/model/person.py	2017-03-17 07:12:19 +0000
@@ -2334,6 +2334,7 @@
             ('bugsubscription', 'person'),
             ('bugsummary', 'viewed_by'),
             ('bugtask', 'assignee'),
+            ('codereviewvote', 'reviewer'),
             ('emailaddress', 'person'),
             ('gitrepository', 'owner'),
             ('gitsubscription', 'person'),


Follow ups