launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> 
> === modified file 'lib/lp/blueprints/browser/configure.zcml'
> --- lib/lp/blueprints/browser/configure.zcml	2014-11-24 06:20:03 +0000
> +++ lib/lp/blueprints/browser/configure.zcml	2017-04-09 08:45:48 +0000
> @@ -78,6 +78,13 @@
>          facet="overview"
>          template="../../../lp/registry/templates/object-branding.pt"/>
>      <browser:page
> +        name="+delete"
> +        for="lp.blueprints.interfaces.sprint.ISprint"
> +        class="lp.blueprints.browser.sprint.SprintDeleteView"
> +        permission="launchpad.Edit"

I think we'll also need lp.security changes so ~registry has launchpad.Edit?

> +        facet="overview"
> +        template="../templates/sprint-delete.pt"/>
> +    <browser:page
>          name="+attend"
>          for="lp.blueprints.interfaces.sprint.ISprint"
>          class="lp.blueprints.browser.sprintattendance.SprintAttendanceAttendView"


-- 
https://code.launchpad.net/~cjwatson/launchpad/delete-sprint/+merge/322255
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.