launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> 
> === modified file 'lib/lp/soyuz/interfaces/binarypackagebuild.py'
> --- lib/lp/soyuz/interfaces/binarypackagebuild.py	2016-01-08 13:15:02 +0000
> +++ lib/lp/soyuz/interfaces/binarypackagebuild.py	2017-03-29 22:36:06 +0000
> @@ -157,6 +161,15 @@
>              ),
>          exported_as="score")
>  
> +    def updateStatus(status, builder=None, slave_status=None,
> +                     date_started=None, date_finished=None,
> +                     force_invalid_transition=False, buildinfo=None):
> +        """See `IBuildFarmJob.updateStatus`.
> +
> +        This version also accepts a `buildinfo` parameter which sets the
> +        build's buildinfo file if it has not already been set.
> +        """

You don't seem to use this enhanced updateStatus anywhere, preferring addBuildInfo in archiveuploader. Is it worth keeping?

> +
>      def updateDependencies():
>          """Update the build-dependencies line within the targeted context."""
>  


-- 
https://code.launchpad.net/~cjwatson/launchpad/store-buildinfo/+merge/321263
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.