launchpad-reviewers team mailing list archive

[Adam Collard <adam.collard@xxxxxxxxxxxxx>]

Review: Approve

LGTM, minor nit inline.

Diff comments:

> 
> === modified file 'lib/lp/code/javascript/tests/test_bugspeclinks.js'
> --- lib/lp/code/javascript/tests/test_bugspeclinks.js	2016-06-25 08:05:06 +0000
> +++ lib/lp/code/javascript/tests/test_bugspeclinks.js	2017-04-18 23:56:38 +0000
> @@ -242,12 +242,31 @@
>          test_unlink_bug_success: function() {
>              this.widget = this._createWidget();
>              // Set up the bug data on the page.
> -            Y.one('#linkbug').setContent('Link to another');
> +            Y.one('#linkbug').setContent('Link to another bug report');
>              Y.one('#buglink-list').appendChild(
> -                Y.Node.create('<div id="buglink-3"></div>'));
> +                Y.Node.create(
> +                    '<div id="buglink-3" class="buglink-summary" />'));
>              this.widget._unlink_bug_success(3);
>              Y.Assert.areEqual(
>                  'Link to a bug report', Y.one('#linkbug').getContent());
> +        },
> +
> +        // If there are still linked bugs remaining after unlinking one, the
> +        // #linkbug text is left unchanged.
> +        test_unlink_bug_branch_still_remaining: function() {
> +            this.widget = this._createWidget();
> +            // Set up the bug data on the page.
> +            Y.one('#linkbug').setContent('Link to another bug report');
> +            console.log(Y.one('#buglink-list'));

leftover debugging?

> +            Y.one('#buglink-list').appendChild(
> +                Y.Node.create(
> +                    '<div id="buglink-3" class="buglink-summary" />'));
> +            Y.one('#buglink-list').appendChild(
> +                Y.Node.create(
> +                    '<div id="buglink-4" class="buglink-summary" />'));
> +            this.widget._unlink_bug_success(3);
> +            Y.Assert.areEqual(
> +                'Link to another bug report', Y.one('#linkbug').getContent());
>          }
>      })));
>  


-- 
https://code.launchpad.net/~cjwatson/launchpad/fix-mp-js-buglink/+merge/322720
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/fix-mp-js-buglink into lp:launchpad.