launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad-buildd/snap-submodules into lp:launchpad-buildd.

Commit message:
buildsnap: Initialise git submodules (LP: #1694413).

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1694413 in launchpad-buildd: "Builder doesn't pull submodules"
  https://bugs.launchpad.net/launchpad-buildd/+bug/1694413

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad-buildd/snap-submodules/+merge/324853
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad-buildd/snap-submodules into lp:launchpad-buildd.

=== modified file 'buildsnap'
--- buildsnap	2017-05-15 16:57:31 +0000
+++ buildsnap	2017-05-31 10:22:43 +0000
@@ -143,7 +143,7 @@
                 cmd.insert(1, "-Ossl.cert_reqs=none")
         else:
             assert self.options.git_repository is not None
-            cmd = ["git", "clone"]
+            cmd = ["git", "clone", "--recursive"]
             if self.options.git_path is not None:
                 cmd.extend(["-b", self.options.git_path])
             cmd.extend([self.options.git_repository, self.name])

=== modified file 'debian/changelog'
--- debian/changelog	2017-05-16 18:54:34 +0000
+++ debian/changelog	2017-05-31 10:22:43 +0000
@@ -1,3 +1,9 @@
+launchpad-buildd (145) UNRELEASED; urgency=medium
+
+  * buildsnap: Initialise git submodules (LP: #1694413).
+
+ -- Colin Watson <cjwatson@xxxxxxxxxx>  Wed, 31 May 2017 11:19:36 +0100
+
 launchpad-buildd (144) xenial; urgency=medium
 
   * buildsnap: Fix revision_id computation to handle the case where