launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/canonical-mojo-specs/snap-proxy-api-snapcraft-io into lp:~canonical-launchpad-branches/canonical-mojo-specs/trunk.

Commit message:
snap-proxy: Whitelist api.snapcraft.io, and add another search.apps.ubuntu.com IP address.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/canonical-mojo-specs/snap-proxy-api-snapcraft-io/+merge/327259
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/canonical-mojo-specs/snap-proxy-api-snapcraft-io into lp:~canonical-launchpad-branches/canonical-mojo-specs/trunk.

=== modified file 'lp/mojo-lp-snap-proxy/production/deploy'
--- lp/mojo-lp-snap-proxy/production/deploy	2017-05-12 12:40:29 +0000
+++ lp/mojo-lp-snap-proxy/production/deploy	2017-07-12 00:15:19 +0000
@@ -85,9 +85,11 @@
                         # people.canonical.com, used by some developers to
                         # host blobs.
                         91.189.89.62,
-                        # search.apps.ubuntu.com, used by snapcraft to fetch
-                        # the core snap for builds of classic snaps.
-                        162.213.33.196, 162.213.33.200,
+                        # search.apps.ubuntu.com/api.snapcraft.io, used by
+                        # snapcraft to fetch the core snap for builds of
+                        # classic snaps.
+                        162.213.33.196, 162.213.33.200, 162.213.33.233,
+                        91.189.92.19, 91.189.92.20,
                         # public.apps.ubuntu.com, used by snapcraft to fetch
                         # the core snap for builds of classic snaps.
                         162.213.33.91, 162.213.33.92,

=== modified file 'lp/mojo-lp-snap-proxy/qastaging/deploy'
--- lp/mojo-lp-snap-proxy/qastaging/deploy	2017-05-12 12:40:29 +0000
+++ lp/mojo-lp-snap-proxy/qastaging/deploy	2017-07-12 00:15:19 +0000
@@ -88,9 +88,11 @@
                         # people.canonical.com, used by some developers to
                         # host blobs.
                         91.189.89.62,
-                        # search.apps.ubuntu.com, used by snapcraft to fetch
-                        # the core snap for builds of classic snaps.
-                        162.213.33.196, 162.213.33.200,
+                        # search.apps.ubuntu.com/api.snapcraft.io, used by
+                        # snapcraft to fetch the core snap for builds of
+                        # classic snaps.
+                        162.213.33.196, 162.213.33.200, 162.213.33.233,
+                        91.189.92.19, 91.189.92.20,
                         # public.apps.ubuntu.com, used by snapcraft to fetch
                         # the core snap for builds of classic snaps.
                         162.213.33.91, 162.213.33.92,