launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #21714
[Merge] lp:~cjwatson/launchpad/eslint-remove-unused-vars into lp:launchpad
Colin Watson has proposed merging lp:~cjwatson/launchpad/eslint-remove-unused-vars into lp:launchpad with lp:~cjwatson/launchpad/eslint-remove-dead-code as a prerequisite.
Commit message:
Remove lots of unused variable assignments spotted by ESLint.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/eslint-remove-unused-vars/+merge/327894
--
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/eslint-remove-unused-vars into lp:launchpad.
=== modified file 'lib/lp/app/javascript/anim/tests/test_anim.js'
--- lib/lp/app/javascript/anim/tests/test_anim.js 2013-03-20 03:41:40 +0000
+++ lib/lp/app/javascript/anim/tests/test_anim.js 2017-07-21 17:11:32 +0000
@@ -52,8 +52,7 @@
test_resolveNodeListFrom_anythine_else: function() {
var succeed = true;
try {
- var nodelist = tests.resolveNodeListFrom(
- {crazy: true, broken: 'definitely'});
+ tests.resolveNodeListFrom({crazy: true, broken: 'definitely'});
} catch(e) {
succeed = false;
}
=== modified file 'lib/lp/app/javascript/gallery-accordion/gallery-accordion.js'
--- lib/lp/app/javascript/gallery-accordion/gallery-accordion.js 2011-03-15 13:29:18 +0000
+++ lib/lp/app/javascript/gallery-accordion/gallery-accordion.js 2017-07-21 17:11:32 +0000
@@ -904,7 +904,7 @@
* @param item {Y.AccordionItem} An <code>Y.AccordionItem</code> instance to be set as draggable
*/
_initItemDragDrop: function( item ){
- var itemHeader, dd, bb, itemBB, ddrop;
+ var itemHeader, dd, bb, itemBB;
itemHeader = item.getStdModNode( WidgetStdMod.HEADER );
@@ -924,7 +924,7 @@
constrain2node: bb
});
- ddrop = new Y.DD.Drop({
+ new Y.DD.Drop({
node: itemBB,
groups: [ DRAGGROUP ]
});
=== modified file 'lib/lp/app/javascript/picker/tests/test_picker_patcher.js'
--- lib/lp/app/javascript/picker/tests/test_picker_patcher.js 2016-09-12 19:41:46 +0000
+++ lib/lp/app/javascript/picker/tests/test_picker_patcher.js 2017-07-21 17:11:32 +0000
@@ -352,7 +352,7 @@
// to copy the selected value to the text input field.
this.text_input = Y.Node.create(
'<input id="field.testfield" value="foo" />');
- var node = Y.one(document.body).appendChild(this.text_input);
+ Y.one(document.body).appendChild(this.text_input);
this.select_menu = Y.Node.create(
'<select id="field.testfield-suggestions"> ' +
' <option value="">Did you mean...</option>' +
=== modified file 'lib/lp/app/javascript/subscribers/tests/test_subscribers_list.js'
--- lib/lp/app/javascript/subscribers/tests/test_subscribers_list.js 2017-07-21 17:11:31 +0000
+++ lib/lp/app/javascript/subscribers/tests/test_subscribers_list.js 2017-07-21 17:11:32 +0000
@@ -110,7 +110,7 @@
test_no_container_error: function() {
// When there is no matching container node in the DOM tree,
// an exception is thrown.
- var sl = new module.SubscribersList({
+ new module.SubscribersList({
container_box: '#not-found',
subscriber_levels: []});
},
@@ -133,7 +133,7 @@
Y.Node.create('<div />').addClass('container'));
this.root.appendChild(
Y.Node.create('<div />').addClass('container'));
- var sl = new module.SubscribersList({
+ new module.SubscribersList({
container_box: '.container',
subscriber_levels: []});
},
@@ -761,7 +761,7 @@
test_removeSectionNodeIfEmpty_keeps_others: function() {
// With two empty sections, only the requested one is removed.
var subscribers_list = setUpSubscribersList(this.root);
- var section_node1 = subscribers_list._getOrCreateSection('Level3');
+ subscribers_list._getOrCreateSection('Level3');
var section_node2 = subscribers_list._getOrCreateSection(
'Level1');
@@ -1187,8 +1187,7 @@
// fails with an exception.
var subscribers_list = setUpSubscribersList(this.root);
var subscriber = { name: 'user' };
- var subscriber_node = subscribers_list.addSubscriber(
- subscriber, 'Level1');
+ subscribers_list.addSubscriber(subscriber, 'Level1');
subscribers_list.addUnsubscribeAction(subscriber, "not-function");
},
@@ -1224,9 +1223,7 @@
// Removing a subscriber works when the subscriber is in the list.
var subscribers_list = setUpSubscribersList(this.root);
var subscriber = { name: 'user' };
- var subscriber_node = subscribers_list.addSubscriber(
- subscriber, 'Level3');
- var section_node = subscriber_node.ancestor('.subscribers-section');
+ subscribers_list.addSubscriber(subscriber, 'Level3');
subscribers_list.removeSubscriber(subscriber);
// Entire section is removed along with the subscriber.
Y.Assert.areEqual(0, _getAllSections(subscribers_list).length);
@@ -1238,9 +1235,7 @@
var subscriber = { name: 'user' };
var other_node = subscribers_list.addSubscriber(
{ name: 'other' }, 'Level3');
- var subscriber_node = subscribers_list.addSubscriber(
- subscriber, 'Level3');
- var section_node = subscriber_node.ancestor('.subscribers-section');
+ subscribers_list.addSubscriber(subscriber, 'Level3');
subscribers_list.removeSubscriber(subscriber);
// Section is not removed because it still has 'other' subscriber.
var all_sections = _getAllSections(subscribers_list);
@@ -1341,7 +1336,7 @@
// When there's no activity in progress, nothing happens.
var subscribers_list = setUpSubscribersList(this.root);
var subscriber = { name: 'user' };
- var node = subscribers_list.addSubscriber(subscriber, 'Level3');
+ subscribers_list.addSubscriber(subscriber, 'Level3');
subscribers_list.stopSubscriberActivity(subscriber);
},
@@ -1454,10 +1449,9 @@
test_SubscribersLoader_container_error: function() {
// If no container node to hold the subscribers list is specified,
// it fails with an error.
- var loader =
- new module.SubscribersLoader({
- container_box: '#not-found',
- subscriber_levels: []});
+ new module.SubscribersLoader({
+ container_box: '#not-found',
+ subscriber_levels: []});
},
test_SubscribersLoader_context_error: function() {
@@ -1999,7 +1993,7 @@
setup_called = true;
};
- var loader = setUpLoader(this.root, config);
+ setUpLoader(this.root, config);
Y.Assert.isTrue(setup_called);
=== modified file 'lib/lp/app/javascript/tests/test_expander.js'
--- lib/lp/app/javascript/tests/test_expander.js 2014-01-24 04:41:21 +0000
+++ lib/lp/app/javascript/tests/test_expander.js 2017-07-21 17:11:32 +0000
@@ -61,7 +61,7 @@
}
var root = this.makeNode();
var hook = root.appendChild(this.makeNode('hook'));
- var icon = hook.appendChild(this.makeNode('icon'));
+ hook.appendChild(this.makeNode('icon'));
var content = hook.appendChild(this.makeNode('content'));
if (args.expanded) {
content.addClass('expanded');
@@ -149,7 +149,7 @@
var root = this.makeExpanderHooks();
var icon = root.one('.icon');
icon.addClass('hidden');
- var expander = this.makeExpander(root);
+ this.makeExpander(root);
Y.Assert.isFalse(icon.hasClass('hidden'));
},
=== modified file 'lib/lp/app/javascript/tests/test_foldables.js'
--- lib/lp/app/javascript/tests/test_foldables.js 2013-03-20 03:41:40 +0000
+++ lib/lp/app/javascript/tests/test_foldables.js 2017-07-21 17:11:32 +0000
@@ -101,7 +101,7 @@
var link = Y.one('a');
link.simulate('click');
- var quote = Y.one('.foldable-quoted');
+ quote = Y.one('.foldable-quoted');
Y.Assert.areSame(quote.getStyle('display'), 'inline');
// Make sure that if clicked again it hides.
=== modified file 'lib/lp/app/javascript/tests/test_longpoll.js'
--- lib/lp/app/javascript/tests/test_longpoll.js 2017-07-21 17:11:31 +0000
+++ lib/lp/app/javascript/tests/test_longpoll.js 2017-07-21 17:11:32 +0000
@@ -94,7 +94,7 @@
Y.on(longpoll.longpoll_start_event, function() {
fired = true;
});
- var manager = this.setupLongPoll();
+ this.setupLongPoll();
Y.Assert.isTrue(fired, "Start event not fired.");
},
=== modified file 'lib/lp/bugs/javascript/bugtask_index.js'
--- lib/lp/bugs/javascript/bugtask_index.js 2017-07-21 17:11:31 +0000
+++ lib/lp/bugs/javascript/bugtask_index.js 2017-07-21 17:11:32 +0000
@@ -545,13 +545,13 @@
(LP.links.me !== null)) {
if (Y.Lang.isValue(bugtarget_content)) {
if (conf.target_is_product) {
- var bugtarget_picker = Y.lp.app.picker.addPickerPatcher(
- 'Product',
- conf.bugtask_path,
- "target_link",
- bugtarget_content.get('id'),
- {"step_title": "Search projects",
- "header": "Change project"});
+ Y.lp.app.picker.addPickerPatcher(
+ 'Product',
+ conf.bugtask_path,
+ "target_link",
+ bugtarget_content.get('id'),
+ {"step_title": "Search projects",
+ "header": "Change project"});
}
}
@@ -1046,7 +1046,7 @@
if (!Y.Lang.isValue(io_provider)) {
io_provider = Y.lp.client.get_configured_io_provider();
}
- var request = io_provider.io(batched_comments_url, {on: handlers});
+ io_provider.io(batched_comments_url, {on: handlers});
};
/**
=== modified file 'lib/lp/bugs/javascript/duplicates.js'
--- lib/lp/bugs/javascript/duplicates.js 2017-07-21 17:11:31 +0000
+++ lib/lp/bugs/javascript/duplicates.js 2017-07-21 17:11:32 +0000
@@ -339,7 +339,6 @@
}
var that = this;
- var spinner = null;
var error_handler = this._error_handler(widget);
var submit_url = LP.cache.context.web_link + '/+duplicate';
var y_config = {
@@ -362,7 +361,7 @@
}
}
that.set('error', null);
- spinner = that._show_bug_spinner(widget);
+ that._show_bug_spinner(widget);
},
success: function(id, response) {
that._submit_bug_success(
=== modified file 'lib/lp/bugs/javascript/filebug.js'
--- lib/lp/bugs/javascript/filebug.js 2014-01-30 15:04:06 +0000
+++ lib/lp/bugs/javascript/filebug.js 2017-07-21 17:11:32 +0000
@@ -11,11 +11,7 @@
var namespace = Y.namespace('lp.bugs.filebug');
var info_type = Y.lp.app.information_type;
-// For tests.
-var skip_animation;
-
-var setup_filebug = function(skip_anim) {
- skip_animation = skip_anim;
+var setup_filebug = function() {
if (LP.cache.enable_bugfiling_duplicate_search) {
Y.lp.bugs.filebug_dupefinder.setup_dupe_finder();
}
=== modified file 'lib/lp/bugs/javascript/tests/test_bug_notification_level.js'
--- lib/lp/bugs/javascript/tests/test_bug_notification_level.js 2013-03-20 03:41:40 +0000
+++ lib/lp/bugs/javascript/tests/test_bug_notification_level.js 2017-07-21 17:11:32 +0000
@@ -216,7 +216,7 @@
var radio_buttons = node.all('input[name="field.subscription"]');
module._bug_notification_level_visible = false;
- var state = module._initialize(radio_buttons, level_node);
+ module._initialize(radio_buttons, level_node);
Y.Assert.isTrue(module._bug_notification_level_visible);
},
=== modified file 'lib/lp/bugs/javascript/tests/test_filebug.js'
--- lib/lp/bugs/javascript/tests/test_filebug.js 2013-03-20 03:41:40 +0000
+++ lib/lp/bugs/javascript/tests/test_filebug.js 2017-07-21 17:11:32 +0000
@@ -57,7 +57,7 @@
}
var form = Y.Node.create(Y.one('#' + form_id).getContent());
this.fixture.appendChild(form);
- Y.lp.bugs.filebug.setup_filebug(true);
+ Y.lp.bugs.filebug.setup_filebug();
},
tearDown: function () {
=== modified file 'lib/lp/bugs/javascript/tests/test_pre_search.js'
--- lib/lp/bugs/javascript/tests/test_pre_search.js 2013-03-20 03:41:40 +0000
+++ lib/lp/bugs/javascript/tests/test_pre_search.js 2017-07-21 17:11:32 +0000
@@ -3,9 +3,8 @@
YUI.add('lp.bugs.bugtask_index.test_pre_search', function (Y) {
var module = Y.lp.bugs.bugtask_index;
- // Local aliases
- var Assert = Y.Assert,
- ArrayAssert = Y.ArrayAssert;
+ // Local alias.
+ var ArrayAssert = Y.ArrayAssert;
// A picker implementation that records method calls for testing.
function FauxPicker() {
=== modified file 'lib/lp/bugs/javascript/tests/test_subscription.js'
--- lib/lp/bugs/javascript/tests/test_subscription.js 2017-07-21 17:11:31 +0000
+++ lib/lp/bugs/javascript/tests/test_subscription.js 2017-07-21 17:11:32 +0000
@@ -2200,8 +2200,7 @@
var args = { bugs: [ { self: { self_link: 'http://bug/' } } ],
teams: [ { self: { self_link: 'http://team1/' } },
{ self: { self_link: 'http://team2/' } }] };
- var data = module._get_unsubscribe_duplicates_text_and_subscriptions(
- args);
+ module._get_unsubscribe_duplicates_text_and_subscriptions(args);
}
}));
@@ -2457,8 +2456,7 @@
var args = { bugs: [ { self: { self_link: 'http://bug/' } } ],
teams: [ { self: { self_link: 'http://team1/' } },
{ self: { self_link: 'http://team2/' } }] };
- var data = module._get_unsubscribe_duplicates_text_and_subscriptions(
- args);
+ module._get_unsubscribe_duplicates_text_and_subscriptions(args);
}
}));
=== modified file 'lib/lp/registry/javascript/distroseries/widgets.js'
--- lib/lp/registry/javascript/distroseries/widgets.js 2013-04-09 05:05:39 +0000
+++ lib/lp/registry/javascript/distroseries/widgets.js 2017-07-21 17:11:32 +0000
@@ -434,7 +434,7 @@
// of the parents is among them.
return true;
}
- var ds, choice;
+ var ds;
for (ds in this._archindep_tags) {
var arch_tag = this._archindep_tags[ds];
var i = 0;
=== modified file 'lib/lp/registry/javascript/distroseriesdifferences_details.js'
--- lib/lp/registry/javascript/distroseriesdifferences_details.js 2013-04-09 05:05:39 +0000
+++ lib/lp/registry/javascript/distroseriesdifferences_details.js 2017-07-21 17:11:32 +0000
@@ -106,7 +106,7 @@
var blacklist_slot = container.one('div.blacklist-options');
if (blacklist_slot !== null) {
- var blacklist_widget = new BlacklistWidget(
+ new BlacklistWidget(
{srcNode: blacklist_slot,
sourceName: source_name,
dsdLink: api_uri,
@@ -617,14 +617,14 @@
namespace.setup = function() {
Y.all('table.listing a.toggle-extra').each(function(toggle){
- var row = new namespace.ExpandableRowWidget({toggle: toggle});
+ new namespace.ExpandableRowWidget({toggle: toggle});
});
};
var set_package_diff_status = function(container, new_status, note_msg) {
container.removeClass('request-derived-diff');
container.removeClass('PENDING');
- note = container.all('.note').remove();
+ container.all('.note').remove();
container.addClass(new_status);
if (note_msg !== undefined) {
container.append([
=== modified file 'lib/lp/registry/javascript/structural-subscription.js'
--- lib/lp/registry/javascript/structural-subscription.js 2017-07-21 17:11:31 +0000
+++ lib/lp/registry/javascript/structural-subscription.js 2017-07-21 17:11:32 +0000
@@ -885,7 +885,7 @@
.set('text', LP.cache.context.title);
add_recipient_picker(content_node, hide_recipient_picker);
- var accordion = create_accordion('#accordion-overlay', content_node);
+ create_accordion('#accordion-overlay', content_node);
// Set up click handlers for the events radio buttons.
var radio_group = Y.all('#events input');
=== modified file 'lib/lp/registry/javascript/tests/test_distroseriesdifferences_details.js'
--- lib/lp/registry/javascript/tests/test_distroseriesdifferences_details.js 2017-07-21 17:11:31 +0000
+++ lib/lp/registry/javascript/tests/test_distroseriesdifferences_details.js 2017-07-21 17:11:32 +0000
@@ -95,7 +95,7 @@
},
test_initializer: function() {
- var row = new module.ExpandableRowWidget({toggle: this.toggle});
+ new module.ExpandableRowWidget({toggle: this.toggle});
Y.Assert.isTrue(this.toggle.hasClass('treeCollapsed'));
Y.Assert.isTrue(this.toggle.hasClass('sprite'));
},
=== modified file 'lib/lp/registry/javascript/tests/test_team_mailinglists.js'
--- lib/lp/registry/javascript/tests/test_team_mailinglists.js 2017-07-21 17:11:31 +0000
+++ lib/lp/registry/javascript/tests/test_team_mailinglists.js 2017-07-21 17:11:32 +0000
@@ -54,8 +54,7 @@
forwards_navigation: Y.all('.last,.next'),
backwards_navigation: Y.all('.first,.previous')
};
- var message_list = new Y.lp.registry.team.mailinglists.MessageList(
- config);
+ new Y.lp.registry.team.mailinglists.MessageList(config);
var fired = false;
Y.on('messageList:backwards', function () {
=== modified file 'lib/lp/soyuz/javascript/base.js'
--- lib/lp/soyuz/javascript/base.js 2011-04-11 06:49:29 +0000
+++ lib/lp/soyuz/javascript/base.js 2017-07-21 17:11:32 +0000
@@ -23,7 +23,7 @@
failure_message.addClass('update-failure-message');
failure_message.one('span').set('text', text);
- var retry_link = failure_message.one('a')
+ failure_message.one('a')
.addClass('update-retry')
.set('href', '')
.on('click', handler);
=== modified file 'lib/lp/testing/tests/test_yuixhr_fixture.js'
--- lib/lp/testing/tests/test_yuixhr_fixture.js 2013-04-08 08:06:09 +0000
+++ lib/lp/testing/tests/test_yuixhr_fixture.js 2017-07-21 17:11:32 +0000
@@ -53,7 +53,7 @@
},
test_teardown_clears_attributes: function() {
- var data = module.setup(this, 'baseline');
+ module.setup(this, 'baseline');
module.teardown(this);
Y.Assert.isUndefined(this._lp_fixture_setups);
Y.Assert.isUndefined(this._lp_fixture_data);
Follow ups
