launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #21736
[Merge] lp:~cjwatson/launchpad/eslint-line-length into lp:launchpad
Colin Watson has proposed merging lp:~cjwatson/launchpad/eslint-line-length into lp:launchpad.
Commit message:
Reformat JS to fit in 80 columns.
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/eslint-line-length/+merge/327976
--
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/eslint-line-length into lp:launchpad.
=== modified file 'lib/lp/app/javascript/confirmationoverlay/tests/test_confirmationoverlay.js'
--- lib/lp/app/javascript/confirmationoverlay/tests/test_confirmationoverlay.js 2013-03-20 03:41:40 +0000
+++ lib/lp/app/javascript/confirmationoverlay/tests/test_confirmationoverlay.js 2017-07-24 15:59:04 +0000
@@ -16,8 +16,9 @@
.empty()
.append(Y.Node.create(form_html));
this.button = Y.one('#submit');
- this.overlay = new Y.lp.app.confirmationoverlay.ConfirmationOverlay(
- {button: this.button});
+ this.overlay =
+ new Y.lp.app.confirmationoverlay.ConfirmationOverlay(
+ {button: this.button});
},
tearDown: function() {
@@ -48,15 +49,16 @@
},
test_hidden_field_added_on_ok: function() {
- // When 'ok' (i.e. confirmation) is clicked, the Confirmation Overlay
- // adds an additional field to the form to simulate the click on the
- // right button.
+ // When 'ok' (i.e. confirmation) is clicked, the Confirmation
+ // Overlay adds an additional field to the form to simulate the
+ // click on the right button.
this.button.simulate('click');
this.overlay.form_node.one('.ok-btn').simulate('click');
var hidden_input = this.overlay.get(
'submit_form').one('input.hidden-input');
- var real_input = this.overlay.get('submit_form').one('input#submit');
+ var real_input = this.overlay.get('submit_form')
+ .one('input#submit');
Y.Assert.areEqual(
real_input.get('name'),
@@ -67,11 +69,11 @@
},
test_call_submit_on_ok: function() {
- // When 'ok' (i.e. confirmation) is clicked, the Confirmation Overlay
- // submits the form.
- // (Since we don't use YUI to make the request, we have to patch the
- // form object to test it's submission (and prevent the form to be
- // actually submitted.)
+ // When 'ok' (i.e. confirmation) is clicked, the Confirmation
+ // Overlay submits the form.
+ // Since we don't use YUI to make the request, we have to patch
+ // the form object to test its submission (and prevent the form
+ // from actually being submitted).
this.button.simulate('click');
var mockForm = Y.Mock();
@@ -116,22 +118,25 @@
},
test_form_content_fn: function() {
- this.overlay = new Y.lp.app.confirmationoverlay.ConfirmationOverlay({
- button: this.button,
- form_content_fn: this.getTestContent
- });
+ this.overlay =
+ new Y.lp.app.confirmationoverlay.ConfirmationOverlay({
+ button: this.button,
+ form_content_fn: this.getTestContent
+ });
Y.one('span#test').set('innerHTML', 'random content');
Y.Assert.areEqual('', this.overlay.get('form_content'));
this.button.simulate('click');
- Y.Assert.areEqual('random content', this.overlay.get('form_content'));
+ Y.Assert.areEqual(
+ 'random content', this.overlay.get('form_content'));
},
test_header_content_fn: function() {
- this.overlay = new Y.lp.app.confirmationoverlay.ConfirmationOverlay({
- button: this.button,
- header_content_fn: this.getTestContent
- });
+ this.overlay =
+ new Y.lp.app.confirmationoverlay.ConfirmationOverlay({
+ button: this.button,
+ header_content_fn: this.getTestContent
+ });
Y.one('span#test').set('innerHTML', 'random content');
Y.Assert.areEqual('', this.overlay.get('form_header'));
@@ -143,11 +148,12 @@
test_do_not_display_fn: function() {
// The parameter display_confirmation_fn can be used
- // to prevent the Confirmation Overlay from popping up.
- this.overlay = new Y.lp.app.confirmationoverlay.ConfirmationOverlay({
- button: this.button,
- display_confirmation_fn: this.isTestNotEmpty
- });
+ // to prevent the Confirmation Overlay from popping up.
+ this.overlay =
+ new Y.lp.app.confirmationoverlay.ConfirmationOverlay({
+ button: this.button,
+ display_confirmation_fn: this.isTestNotEmpty
+ });
// Hack the form to prevent real submission.
Y.one('form').on('submit', function(e) {
@@ -176,10 +182,11 @@
e.preventDefault();
});
- this.overlay = new Y.lp.app.confirmationoverlay.ConfirmationOverlay({
- button: this.button,
- submit_fn: callback
- });
+ this.overlay =
+ new Y.lp.app.confirmationoverlay.ConfirmationOverlay({
+ button: this.button,
+ submit_fn: callback
+ });
this.button.simulate('click');
Y.Assert.isTrue(this.overlay.get('visible'));
this.overlay.form_node.one('.ok-btn').simulate('click');
@@ -203,16 +210,18 @@
},
test_callback_called: function() {
- // A ConfirmationOverlay can be constructed without passing a button.
- // The creator is responsible for calling show() manually.
+ // A ConfirmationOverlay can be constructed without passing a
+ // button. The creator is responsible for calling show()
+ // manually.
var called = false;
var callback = function() {
called = true;
};
- this.overlay = new Y.lp.app.confirmationoverlay.ConfirmationOverlay({
- submit_fn: callback
- });
+ this.overlay =
+ new Y.lp.app.confirmationoverlay.ConfirmationOverlay({
+ submit_fn: callback
+ });
Y.Assert.isFalse(this.overlay.get('visible'));
this.overlay.show();
Y.Assert.isTrue(this.overlay.get('visible'));
=== modified file 'lib/lp/app/javascript/picker/tests/test_picker.js'
--- lib/lp/app/javascript/picker/tests/test_picker.js 2017-07-21 17:35:14 +0000
+++ lib/lp/app/javascript/picker/tests/test_picker.js 2017-07-24 15:59:04 +0000
@@ -767,7 +767,7 @@
"The widget hasn't been cleared");
},
- test_save_does_not_clear_widget_when_clear_on_save_is_false: function () {
+ test_save_does_not_clear_widget_when_clear_on_save_false: function () {
var picker = new Y.lp.ui.picker.Picker({clear_on_save: false});
picker.render();
@@ -1145,7 +1145,8 @@
test_text_input_on_footer_can_be_focused: function () {
this.picker.render();
this.picker.set('footer_slot', Y.Node.create(
- '<input class="extra-input" name="extra_input" type="text" />'));
+ '<input class="extra-input" name="extra_input" ' +
+ 'type="text" />'));
var extra_input =
this.picker.get('boundingBox').one('.extra-input');
var got_focus = false;
=== modified file 'lib/lp/app/javascript/testing/helpers.js'
--- lib/lp/app/javascript/testing/helpers.js 2014-01-30 15:04:06 +0000
+++ lib/lp/app/javascript/testing/helpers.js 2017-07-24 15:59:04 +0000
@@ -26,10 +26,10 @@
* Useful for testing calls to lp.client in other code, though it requires
* the other code be setup so that it can accept a passed in client.
*
- * USAGE: LPClient calls have two sets of 'args'. There are the args you pass
- * into the function call (e.g. `client.get(args)`) and the args set on
- * the callee (e.g. client.get.args). The latter must be set or an error
- * is thrown, though it can be set to nothing.
+ * USAGE: LPClient calls have two sets of 'args'. There are the args you
+ * pass into the function call (e.g. `client.get(args)`) and the args set
+ * on the callee (e.g. client.get.args). The latter must be set or an
+ * error is thrown, though it can be set to nothing.
*
* EXAMPLE:
* var client = new ns.LPCLient();
=== modified file 'lib/lp/app/javascript/testing/tests/test_mockio.js'
--- lib/lp/app/javascript/testing/tests/test_mockio.js 2017-07-21 16:43:02 +0000
+++ lib/lp/app/javascript/testing/tests/test_mockio.js 2017-07-24 15:59:04 +0000
@@ -200,5 +200,6 @@
}));
}, '0.1', {
- 'requires': ['test', 'test-console', 'lp.testing.mockio', 'node-event-simulate']
+ 'requires': [
+ 'test', 'test-console', 'lp.testing.mockio', 'node-event-simulate']
});
=== modified file 'lib/lp/app/javascript/tests/test_ajax_batch_navigator.js'
--- lib/lp/app/javascript/tests/test_ajax_batch_navigator.js 2013-03-20 03:41:40 +0000
+++ lib/lp/app/javascript/tests/test_ajax_batch_navigator.js 2017-07-24 15:59:04 +0000
@@ -180,6 +180,7 @@
})
));
}, '0.1', {
- 'requires': ['test', 'test-console', 'lp.testing.runner', 'lp.testing.mockio',
+ 'requires': [
+ 'test', 'test-console', 'lp.testing.runner', 'lp.testing.mockio',
'base', 'node', 'node-event-simulate', 'lp.app.batchnavigator']
});
=== modified file 'lib/lp/app/javascript/tests/test_comment.js'
--- lib/lp/app/javascript/tests/test_comment.js 2017-07-21 16:43:02 +0000
+++ lib/lp/app/javascript/tests/test_comment.js 2017-07-24 15:59:04 +0000
@@ -18,8 +18,8 @@
var comment = new Y.lp.app.comment.Comment();
Y.Assert.isObject(comment.comment_input);
Y.Assert.isObject(comment.submit_button);
- Y.Assert.isTrue(
- comment.progress_message.hasClass('update-in-progress-message'));
+ Y.Assert.isTrue(comment.progress_message.hasClass(
+ 'update-in-progress-message'));
},
test_validation: function () {
=== modified file 'lib/lp/app/javascript/tests/test_longpoll.js'
--- lib/lp/app/javascript/tests/test_longpoll.js 2017-07-21 17:35:14 +0000
+++ lib/lp/app/javascript/tests/test_longpoll.js 2017-07-24 15:59:04 +0000
@@ -277,6 +277,7 @@
}));
}, '0.1', {
- requires: ['lp.testing.runner', 'test', 'test-console', 'node-event-simulate',
- 'json', 'lp.app.longpoll']
+ requires: [
+ 'lp.testing.runner', 'test', 'test-console', 'node-event-simulate',
+ 'json', 'lp.app.longpoll']
});
=== modified file 'lib/lp/app/javascript/ui/ui.js'
--- lib/lp/app/javascript/ui/ui.js 2013-03-20 03:41:40 +0000
+++ lib/lp/app/javascript/ui/ui.js 2017-07-24 15:59:04 +0000
@@ -31,7 +31,8 @@
* @type String
* @static
*/
-UI.CANCEL_BUTTON = '<button type="button" class="lazr-neg lazr-btn">Cancel</button>';
+UI.CANCEL_BUTTON =
+ '<button type="button" class="lazr-neg lazr-btn">Cancel</button>';
/**
* The standard 'search' glyph as an HTML button template. Used for
@@ -44,7 +45,8 @@
* @type String
* @static
*/
-UI.SEARCH_BUTTON = '<button type="button" class="lazr-search lazr-btn">Search</button>';
+UI.SEARCH_BUTTON =
+ '<button type="button" class="lazr-search lazr-btn">Search</button>';
/**
* The standard 'previous' glyph as an HTML button template. Used for
@@ -57,7 +59,8 @@
* @type String
* @static
*/
-UI.PREVIOUS_BUTTON = '<button type="button" class="lazr-prev lazr-btn">Previous</button>';
+UI.PREVIOUS_BUTTON =
+ '<button type="button" class="lazr-prev lazr-btn">Previous</button>';
/**
* The standard 'next' glyph as an HTML button template. Used for
@@ -70,7 +73,8 @@
* @type String
* @static
*/
-UI.NEXT_BUTTON = '<button type="button" class="lazr-next lazr-btn">Next</button>';
+UI.NEXT_BUTTON =
+ '<button type="button" class="lazr-next lazr-btn">Next</button>';
/**
* Standard CSS class for even elements in a listing.
=== modified file 'lib/lp/blueprints/javascript/tests/test_addspec.js'
--- lib/lp/blueprints/javascript/tests/test_addspec.js 2013-03-20 03:41:40 +0000
+++ lib/lp/blueprints/javascript/tests/test_addspec.js 2017-07-24 15:59:04 +0000
@@ -56,5 +56,6 @@
}));
}, '0.1', {
- requires: ['lp.testing.runner', 'test', 'test-console', 'lp.blueprints.addspec']
+ requires: [
+ 'lp.testing.runner', 'test', 'test-console', 'lp.blueprints.addspec']
});
=== modified file 'lib/lp/blueprints/javascript/tests/test_workitems.js'
--- lib/lp/blueprints/javascript/tests/test_workitems.js 2017-07-21 16:43:02 +0000
+++ lib/lp/blueprints/javascript/tests/test_workitems.js 2017-07-24 15:59:04 +0000
@@ -146,7 +146,8 @@
}));
}, '0.1', {
- requires: ['lp.testing.runner', 'test', 'test-console', 'node', 'lp.ui.picker-base',
- 'lp.workitems.expanders',
- 'event', 'node-event-simulate', 'dump']
+ requires: [
+ 'lp.testing.runner', 'test', 'test-console', 'node',
+ 'lp.ui.picker-base', 'lp.workitems.expanders',
+ 'event', 'node-event-simulate', 'dump']
});
=== modified file 'lib/lp/bugs/javascript/bug_subscription_portlet.js'
--- lib/lp/bugs/javascript/bug_subscription_portlet.js 2017-07-20 13:26:16 +0000
+++ lib/lp/bugs/javascript/bug_subscription_portlet.js 2017-07-24 15:59:04 +0000
@@ -144,13 +144,15 @@
current_class = MUTED_CLASS;
destination_class = UNMUTED_CLASS;
destination_text = 'Mute bug mail';
- destination_title = 'Mute this bug so that you will not receive emails about it.';
+ destination_title =
+ 'Mute this bug so that you will not receive emails about it.';
} else {
method_name = 'mute';
current_class = UNMUTED_CLASS;
destination_class = MUTED_CLASS;
destination_text = 'Unmute bug mail';
- destination_title = 'Unmute this bug so that you will receive emails about it.';
+ destination_title =
+ 'Unmute this bug so that you will receive emails about it.';
}
link.replaceClass(current_class, 'spinner');
var handler = new Y.lp.client.ErrorHandler();
=== modified file 'lib/lp/bugs/javascript/tests/test_bug_subscription_portlet.js'
--- lib/lp/bugs/javascript/tests/test_bug_subscription_portlet.js 2017-07-21 17:35:14 +0000
+++ lib/lp/bugs/javascript/tests/test_bug_subscription_portlet.js 2017-07-24 15:59:04 +0000
@@ -49,8 +49,8 @@
notifications_text: {
not_only_other_subscription: 'You are',
only_other_subscription:
- 'You have subscriptions that may cause you to receive ' +
- 'notifications, but you are',
+ 'You have subscriptions that may cause you to ' +
+ 'receive notifications, but you are',
direct_all: 'subscribed to all notifications for this bug.',
direct_metadata:
'subscribed to all notifications except comments for ' +
@@ -351,13 +351,15 @@
Y.Assert.areEqual('Add a mail subscription for this bug',
overlay.one('h2').get('text'));
// There is no status.
- Y.Assert.isFalse(Y.Lang.isValue(overlay.one('.subscription-status')));
+ Y.Assert.isFalse(
+ Y.Lang.isValue(overlay.one('.subscription-status')));
// The action links are visible.
var action_links = overlay.one('.subscription-actions');
Y.Assert.isFalse(action_links.one(
'.Discussion a').hasClass('hidden'));
Y.Assert.isFalse(action_links.one('.Details a').hasClass('hidden'));
- Y.Assert.isFalse(action_links.one('.Lifecycle a').hasClass('hidden'));
+ Y.Assert.isFalse(
+ action_links.one('.Lifecycle a').hasClass('hidden'));
// The "Remove" link is not present.
Y.Assert.isFalse(Y.Lang.isValue(overlay.one('a.remove')));
// The link is spinning.
@@ -372,7 +374,8 @@
},
test_overlay_with_discussion_subscription: function() {
- // Starting with a DISCUSSION subscription, we get a "change" overlay.
+ // Starting with a DISCUSSION subscription, we get a "change"
+ // overlay.
this.init(DISCUSSION, false);
this.link().simulate('click');
var overlay = Y.one('.pretty-overlay-window');
@@ -389,9 +392,11 @@
'span.Lifecycle').hasClass('hidden'));
// The action links are visible except for Discussion.
var action_links = overlay.one('.subscription-actions');
- Y.Assert.isTrue(action_links.one('.Discussion a').hasClass('hidden'));
+ Y.Assert.isTrue(
+ action_links.one('.Discussion a').hasClass('hidden'));
Y.Assert.isFalse(action_links.one('.Details a').hasClass('hidden'));
- Y.Assert.isFalse(action_links.one('.Lifecycle a').hasClass('hidden'));
+ Y.Assert.isFalse(
+ action_links.one('.Lifecycle a').hasClass('hidden'));
// We have a remove link.
Y.Assert.isTrue(Y.Lang.isValue(overlay.one('a.remove')));
Y.Assert.areEqual(
@@ -417,7 +422,8 @@
Y.Assert.isFalse(action_links.one(
'.Discussion a').hasClass('hidden'));
Y.Assert.isTrue(action_links.one('.Details a').hasClass('hidden'));
- Y.Assert.isFalse(action_links.one('.Lifecycle a').hasClass('hidden'));
+ Y.Assert.isFalse(
+ action_links.one('.Lifecycle a').hasClass('hidden'));
// We have a remove link.
Y.Assert.isTrue(Y.Lang.isValue(overlay.one('a.remove')));
Y.Assert.areEqual(
@@ -443,7 +449,8 @@
Y.Assert.isFalse(action_links.one(
'.Discussion a').hasClass('hidden'));
Y.Assert.isFalse(action_links.one('.Details a').hasClass('hidden'));
- Y.Assert.isTrue(action_links.one('.Lifecycle a').hasClass('hidden'));
+ Y.Assert.isTrue(
+ action_links.one('.Lifecycle a').hasClass('hidden'));
// We have a remove link.
Y.Assert.isTrue(Y.Lang.isValue(overlay.one('a.remove')));
Y.Assert.areEqual(
@@ -457,7 +464,8 @@
Y.Assert.isTrue(this.mute_node.hasClass('hidden'));
this.link().simulate('click');
var overlay = Y.one('.pretty-overlay-window');
- overlay.one('.subscription-actions .Discussion a').simulate('click');
+ overlay.one('.subscription-actions .Discussion a')
+ .simulate('click');
// The overlay has been destroyed, and the spinner is gone.
Y.Assert.isFalse(Y.Lang.isValue(Y.one('.pretty-overlay-window')));
Y.Assert.isFalse(this.link().hasClass('spinner'));
=== modified file 'lib/lp/bugs/javascript/tests/test_me_too.js'
--- lib/lp/bugs/javascript/tests/test_me_too.js 2017-07-21 16:43:02 +0000
+++ lib/lp/bugs/javascript/tests/test_me_too.js 2017-07-24 15:59:04 +0000
@@ -37,7 +37,8 @@
var inpage = Y.Node.create([
'<span id="affectsmetoo">',
' <span class="static">',
- ' <img src="https://bugs.launchpad.net/@@/flame-icon"; alt=""/>',
+ ' <img src="https://bugs.launchpad.net/@@/flame-icon"; ',
+ ' alt=""/>',
' This bug affects me too',
' <a href="+affectsmetoo">',
' <img class="editicon" alt="Edit"',
@@ -47,9 +48,11 @@
' <span class="dynamic hidden">',
' <img class="editicon" alt="Edit"',
' src="https://bugs.launchpad.net/@@/edit"; />',
- ' <a href="+affectsmetoo" class="js-action"',
- ' ><span class="value">Does this bug affect you?</span></a>',
- ' <img src="https://bugs.launchpad.net/@@/flame-icon"; alt=""/>',
+ ' <a href="+affectsmetoo" class="js-action">',
+ ' <span class="value">Does this bug affect you?</span>',
+ ' </a>',
+ ' <img src="https://bugs.launchpad.net/@@/flame-icon"; ',
+ ' alt=""/>',
' </span>',
'</span>'].join(''));
Y.one("body").appendChild(inpage);
=== modified file 'lib/lp/bugs/javascript/tests/test_official_bug_tags.js'
--- lib/lp/bugs/javascript/tests/test_official_bug_tags.js 2017-07-21 17:35:14 +0000
+++ lib/lp/bugs/javascript/tests/test_official_bug_tags.js 2017-07-24 15:59:04 +0000
@@ -47,6 +47,7 @@
}));
}, '0.1', {
- requires: ['lp.testing.runner', 'test', 'test-console', 'node',
- 'event-simulate', 'node-event-simulate', 'lp.bugs.official_bug_tags']
+ requires: [
+ 'lp.testing.runner', 'test', 'test-console', 'node',
+ 'event-simulate', 'node-event-simulate', 'lp.bugs.official_bug_tags']
});
=== modified file 'lib/lp/bugs/javascript/tests/test_subscribers.js'
--- lib/lp/bugs/javascript/tests/test_subscribers.js 2012-10-26 10:00:20 +0000
+++ lib/lp/bugs/javascript/tests/test_subscribers.js 2017-07-24 15:59:04 +0000
@@ -38,9 +38,10 @@
},
test_addSubscriber: function() {
- // Check that the subscription list has been created with the expected
- // subscription levels for bugs. This can be done by adding a
- // subscriber to one of the expected levels and checking the results.
+ // Check that the subscription list has been created with the
+ // expected subscription levels for bugs. This can be done by
+ // adding a subscriber to one of the expected levels and checking
+ // the results.
var loader = this.setUpLoader(this.root);
var node = loader.subscribers_list.addSubscriber(
{ name: 'user' }, 'Lifecycle');
=== modified file 'lib/lp/bugs/javascript/tests/test_subscription.js'
--- lib/lp/bugs/javascript/tests/test_subscription.js 2017-07-22 21:38:52 +0000
+++ lib/lp/bugs/javascript/tests/test_subscription.js 2017-07-24 15:59:04 +0000
@@ -363,11 +363,13 @@
as_team_member: [],
as_team_admin: []
};
- var subs = module._gather_subscriptions_as_supervisor(mock_category);
+ var subs = module._gather_subscriptions_as_supervisor(
+ mock_category);
Y.Assert.areEqual(1, subs.length);
Y.Assert.areEqual(module._reasons.YOU_OWNER, subs[0].reason);
Y.Assert.areEqual('project', subs[0].vars.pillar);
- Y.Assert.areEqual(module._actions.SET_BUG_SUPERVISOR, subs[0].action);
+ Y.Assert.areEqual(
+ module._actions.SET_BUG_SUPERVISOR, subs[0].action);
},
test_personal_multiple: function() {
@@ -381,7 +383,8 @@
as_team_member: [],
as_team_admin: []
};
- var subs = module._gather_subscriptions_as_supervisor(mock_category);
+ var subs = module._gather_subscriptions_as_supervisor(
+ mock_category);
Y.Assert.areEqual(2, subs.length);
},
@@ -395,7 +398,8 @@
pillar: 'project' }],
as_team_admin: []
};
- var subs = module._gather_subscriptions_as_supervisor(mock_category);
+ var subs = module._gather_subscriptions_as_supervisor(
+ mock_category);
Y.Assert.areEqual(1, subs.length);
Y.Assert.areEqual(module._reasons.TEAM_OWNER, subs[0].reason);
// And there is a 'team' variable containing the team object.
@@ -417,7 +421,8 @@
pillar: {display_name: 'distro'} }],
as_team_admin: []
};
- var subs = module._gather_subscriptions_as_supervisor(mock_category);
+ var subs = module._gather_subscriptions_as_supervisor(
+ mock_category);
Y.Assert.areEqual(2, subs.length);
},
@@ -431,14 +436,16 @@
as_team_admin: [{ principal: 'my team',
pillar: 'project' }]
};
- var subs = module._gather_subscriptions_as_supervisor(mock_category);
+ var subs = module._gather_subscriptions_as_supervisor(
+ mock_category);
Y.Assert.areEqual(1, subs.length);
Y.Assert.areEqual(
module._reasons.ADMIN_TEAM_OWNER, subs[0].reason);
// And there is a 'team' variable containing the team object.
Y.Assert.areEqual('my team', subs[0].vars.team);
Y.Assert.areEqual('project', subs[0].vars.pillar);
- Y.Assert.areEqual(module._actions.SET_BUG_SUPERVISOR, subs[0].action);
+ Y.Assert.areEqual(
+ module._actions.SET_BUG_SUPERVISOR, subs[0].action);
},
test_team_admin_multiple: function() {
@@ -454,7 +461,8 @@
{ principal: 'team2',
pillar: {display_name: 'distro'} }]
};
- var subs = module._gather_subscriptions_as_supervisor(mock_category);
+ var subs = module._gather_subscriptions_as_supervisor(
+ mock_category);
Y.Assert.areEqual(2, subs.length);
},
@@ -470,11 +478,13 @@
as_team_member: [],
as_team_admin: []
};
- var subs = module._gather_subscriptions_as_supervisor(mock_category);
+ var subs = module._gather_subscriptions_as_supervisor(
+ mock_category);
Y.Assert.areEqual(1, subs.length);
Y.Assert.areEqual(module._reasons.YOU_OWNER, subs[0].reason);
Y.Assert.areEqual(mock_pillar, subs[0].vars.pillar.self);
- Y.Assert.areEqual(module._actions.SET_BUG_SUPERVISOR, subs[0].action);
+ Y.Assert.areEqual(
+ module._actions.SET_BUG_SUPERVISOR, subs[0].action);
},
test_combined: function() {
@@ -504,7 +514,8 @@
}],
as_team_admin: []
};
- var subs = module._gather_subscriptions_as_supervisor(mock_category);
+ var subs = module._gather_subscriptions_as_supervisor(
+ mock_category);
Y.Assert.areEqual('My team', subs[0].vars.team.title);
Y.Assert.areEqual('http://link', subs[0].vars.team.url);
@@ -1360,7 +1371,9 @@
// ObjectLink variables get turned into actual HTML links.
var sub = {
reason: 'test string with {foo}',
- vars: { foo: this._constructObjectLink('Title', 'http://link/') }
+ vars: {
+ foo: this._constructObjectLink('Title', 'http://link/')
+ }
};
Y.Assert.areEqual(
@@ -1569,7 +1582,8 @@
node.one('#'+reductions[i]).hasClass('hidden'));
}
Y.Assert.isTrue(
- node.one('#'+module._action_ids.unsubscribe).hasClass('hidden'));
+ node.one('#'+module._action_ids.unsubscribe)
+ .hasClass('hidden'));
for (i = 0; i < increasing_ids.length; i++) {
Y.Assert.isTrue(
node.one('#'+increasing_ids[i]).hasClass('hidden'));
@@ -2115,8 +2129,9 @@
test_yourself_single_bug: function() {
// There is a single duplicate bug you are subscribed to.
var args = { bugs: [ { self: { self_link: 'http://bug/' } } ] };
- var data = module._get_unsubscribe_duplicates_text_and_subscriptions(
- args);
+ var data =
+ module._get_unsubscribe_duplicates_text_and_subscriptions(
+ args);
Y.Assert.areEqual('Unsubscribe yourself from the duplicate',
data.text);
Y.Assert.areEqual(1, data.subscriptions.length);
@@ -2129,8 +2144,9 @@
// There is a single duplicate bug you are subscribed to.
var args = { bugs: [ { self: { self_link: 'http://bug1/' } },
{ self: { self_link: 'http://bug2/' } }] };
- var data = module._get_unsubscribe_duplicates_text_and_subscriptions(
- args);
+ var data =
+ module._get_unsubscribe_duplicates_text_and_subscriptions(
+ args);
Y.Assert.areEqual('Unsubscribe yourself from all duplicates',
data.text);
Y.Assert.areEqual(2, data.subscriptions.length);
@@ -2147,8 +2163,9 @@
// There is a single duplicate bug you are subscribed to.
var args = { bugs: [ { self: { self_link: 'http://bug/' } } ],
teams: [ { self: { self_link: 'http://team/' } } ] };
- var data = module._get_unsubscribe_duplicates_text_and_subscriptions(
- args);
+ var data =
+ module._get_unsubscribe_duplicates_text_and_subscriptions(
+ args);
Y.Assert.areEqual('Unsubscribe this team from the duplicate',
data.text);
Y.Assert.areEqual(1, data.subscriptions.length);
@@ -2162,8 +2179,9 @@
var args = { bugs: [ { self: { self_link: 'http://bug1/' } },
{ self: { self_link: 'http://bug2/' } }],
teams: [ { self: { self_link: 'http://team/' } } ] };
- var data = module._get_unsubscribe_duplicates_text_and_subscriptions(
- args);
+ var data =
+ module._get_unsubscribe_duplicates_text_and_subscriptions(
+ args);
Y.Assert.areEqual('Unsubscribe this team from all duplicates',
data.text);
Y.Assert.areEqual(2, data.subscriptions.length);
@@ -2278,8 +2296,8 @@
get_subscriptions: function () {
// Usually multiple subscriptions will share a subscriber. This
- // function under test does not actually care, so we make it possible
- // to distinguish between the first and the second.
+ // function under test does not actually care, so we make it
+ // possible to distinguish between the first and the second.
return [{subscriber: 'http://example.net/~person1',
bug: 'http://example.net/firefox/bug/1'},
{subscriber: 'http://example.net/~person2',
@@ -2316,7 +2334,8 @@
Y.Assert.isFalse(node.hasClass('spinner'));
// The subscriptions array is empty.
Y.Assert.areEqual(subscriptions.length, 0);
- // We called unsubscribe on the server once, with the right arguments.
+ // We called unsubscribe on the server once, with the right
+ // arguments.
Y.Assert.areEqual(module._lp_client.received.length, 1);
Y.Assert.areEqual(module._lp_client.received[0][0], 'named_post');
var args = module._lp_client.received[0][1];
@@ -2404,7 +2423,8 @@
test_single_team: function() {
// There is a single team you admin that is subscribed to the bug.
var args = { teams: [ { self: { self_link: 'http://team/' } } ] };
- var data = module._get_team_unsubscribe_text_and_subscriptions(args);
+ var data = module._get_team_unsubscribe_text_and_subscriptions(
+ args);
Y.Assert.areEqual('Unsubscribe this team', data.text);
Y.Assert.areEqual(1, data.subscriptions.length);
var sub = data.subscriptions[0];
@@ -2413,10 +2433,12 @@
},
test_multiple_teams: function() {
- // There are multiple teams you admin that are subscribed to the bug.
+ // There are multiple teams you admin that are subscribed to the
+ // bug.
var args = { teams: [ { self: { self_link: 'http://team1/' } },
{ self: { self_link: 'http://team2/' } }] };
- var data = module._get_team_unsubscribe_text_and_subscriptions(args);
+ var data = module._get_team_unsubscribe_text_and_subscriptions(
+ args);
Y.Assert.areEqual('Unsubscribe all of these teams', data.text);
Y.Assert.areEqual(2, data.subscriptions.length);
var sub = data.subscriptions[0];
@@ -2460,7 +2482,8 @@
test_change_assignees: function() {
// Change assignees action.
var link = module._actions.CHANGE_ASSIGNEES();
- Y.Assert.areEqual('Change assignees for this bug', link.get('text'));
+ Y.Assert.areEqual(
+ 'Change assignees for this bug', link.get('text'));
Y.Assert.areEqual('http://test/', link.get('href'));
},
=== modified file 'lib/lp/code/javascript/branchmergeproposal.status.js'
--- lib/lp/code/javascript/branchmergeproposal.status.js 2017-07-21 17:35:14 +0000
+++ lib/lp/code/javascript/branchmergeproposal.status.js 2017-07-24 15:59:04 +0000
@@ -33,12 +33,13 @@
success: function(entry) {
var cb = status_choice_edit.get('contentBox');
Y.Array.each(conf.status_widget_items, function(item) {
- if (item.value == status_choice_edit.get('value')) {
- cb.one('a').addClass(item.css_class);
- } else {
- cb.one('a').removeClass(item.css_class);
- }
- });
+ if (item.value ==
+ status_choice_edit.get('value')) {
+ cb.one('a').addClass(item.css_class);
+ } else {
+ cb.one('a').removeClass(item.css_class);
+ }
+ });
update_summary();
},
end: function() {
@@ -99,7 +100,8 @@
// Don't mess with the diff.
if (new_row.get('innerHTML') !=
old_row.get('innerHTML')) {
- existing_summary.insertBefore(new_row, old_row);
+ existing_summary.insertBefore(
+ new_row, old_row);
old_row.remove();
}
}
=== modified file 'lib/lp/code/javascript/tests/test_branchmergeproposal.inlinecomments.js'
--- lib/lp/code/javascript/tests/test_branchmergeproposal.inlinecomments.js 2017-07-21 11:01:00 +0000
+++ lib/lp/code/javascript/tests/test_branchmergeproposal.inlinecomments.js 2017-07-24 15:59:04 +0000
@@ -366,7 +366,8 @@
var comment = Y.one(
'.diff-content table tbody tr td').next();
Y.Assert.areSame(
- "=== zbqvsvrq svyr 'yvo/yc/nafjref/grfgf/grfg_dhrfgvba_jrofreivpr.cl'",
+ "=== zbqvsvrq svyr " +
+ "'yvo/yc/nafjref/grfgf/grfg_dhrfgvba_jrofreivpr.cl'",
comment.get('text').trim());
// The option corresponding to the current 'preview_diff'
=== modified file 'lib/lp/code/javascript/tests/test_branchmergeproposal.nominate.js'
--- lib/lp/code/javascript/tests/test_branchmergeproposal.nominate.js 2015-10-22 00:13:43 +0000
+++ lib/lp/code/javascript/tests/test_branchmergeproposal.nominate.js 2017-07-24 15:59:04 +0000
@@ -123,8 +123,8 @@
// Invoke the validation callback with the specified visible branches.
// The branches to check is always ['b1', 'b2'] and the person name is
- // always 'Fred'. We are checking the correct behaviour depending on what
- // visible branches are passed in.
+ // always 'Fred'. We are checking the correct behaviour depending on
+ // what visible branches are passed in.
_invoke_confirm_reviewer: function(visible_branches) {
var orig_yesyno = Y.lp.app.picker.yesno_save_confirmation;
var dummy_picker = {};
@@ -187,9 +187,9 @@
tests.suite.add(new Y.Test.Case(Y.merge(TestMixin, {
name: 'branchmergeproposal-nominate-propose-merge-tests',
- // Test that the Propose Merge submit button is re-wired to perform an XHR
- // call and that the correct data is passed and the expected callback is
- // invoked with the returned data.
+ // Test that the Propose Merge submit button is re-wired to perform an
+ // XHR call and that the correct data is passed and the expected
+ // callback is invoked with the returned data.
test_setup_nominate_submit: function() {
var orig_confirm_reviewer_nomination
= module.confirm_reviewer_nomination;
@@ -223,7 +223,8 @@
responseText: '{"person_name": "Fred"}',
responseHeaders: {'Content-Type': 'application/json'}});
Y.Assert.isTrue(confirm_reviewer_nomination_called);
- module.confirm_reviewer_nomination = orig_confirm_reviewer_nomination;
+ module.confirm_reviewer_nomination =
+ orig_confirm_reviewer_nomination;
},
// Test the confirmation prompt when a mp is submitted and the reviewer
@@ -256,8 +257,8 @@
form.submit = orig_submit;
},
- // Test that when a mp is submitted without any confirmation prompt being
- // required, the response is used to redirect to the new page.
+ // Test that when a mp is submitted without any confirmation prompt
+ // being required, the response is used to redirect to the new page.
test_merge_proposal_submission: function() {
var orig_redirect = module._redirect;
var redirect_called = false;
=== modified file 'lib/lp/code/javascript/tests/test_productseries_setbranch.js'
--- lib/lp/code/javascript/tests/test_productseries_setbranch.js 2017-07-22 21:38:52 +0000
+++ lib/lp/code/javascript/tests/test_productseries_setbranch.js 2017-07-24 15:59:04 +0000
@@ -179,7 +179,8 @@
}));
}, '0.1', {
- requires: ['lp.testing.runner', 'node-event-simulate', 'test', 'test-console',
+ requires: ['lp.testing.runner', 'node-event-simulate',
+ 'test', 'test-console',
'Event', 'CustomEvent',
'lp.code.productseries_setbranch']
});
=== modified file 'lib/lp/code/javascript/tests/test_util.js'
--- lib/lp/code/javascript/tests/test_util.js 2016-10-13 14:46:41 +0000
+++ lib/lp/code/javascript/tests/test_util.js 2017-07-24 15:59:04 +0000
@@ -79,6 +79,6 @@
}));
}, '0.1', {
- requires: ['test', 'test-console', 'node-event-simulate', 'lp.testing.runner',
- 'lp.code.util']
+ requires: ['test', 'test-console', 'node-event-simulate',
+ 'lp.testing.runner', 'lp.code.util']
});
=== modified file 'lib/lp/registry/javascript/distroseries/initseries.js'
--- lib/lp/registry/javascript/distroseries/initseries.js 2014-07-22 09:51:52 +0000
+++ lib/lp/registry/javascript/distroseries/initseries.js 2017-07-24 15:59:04 +0000
@@ -298,8 +298,10 @@
new widgets.PackagesetPickerWidget()
.set("name", "field.packagesets")
.set("size", 5)
- .set("help", {link: '/+help-registry/init-series-packageset-help.html',
- text: 'Packagesets help'})
+ .set("help", {
+ link: '/+help-registry/init-series-packageset-help.html',
+ text: 'Packagesets help'
+ })
.set("multiple", true)
.set("label", "Package sets to copy from parent:")
.set("description",
=== modified file 'lib/lp/registry/javascript/tests/test_distroseriesdifferences_details.js'
--- lib/lp/registry/javascript/tests/test_distroseriesdifferences_details.js 2017-07-21 17:35:14 +0000
+++ lib/lp/registry/javascript/tests/test_distroseriesdifferences_details.js 2017-07-24 15:59:04 +0000
@@ -15,10 +15,11 @@
* @param package_name {String} The name of the package for this row.
* @param parent_version {String} The version for the package in the parent
* series.
- * @param derived_version {String} The version for the package in the derived
- * series.
- * @missing_row {Boolean} If false, generate a row of the +localpackagediffs
- * page, if true, generate a row of te +missingpackages page.
+ * @param derived_version {String} The version for the package in the
+ * derived series.
+ * @missing_row {Boolean} If false, generate a row of the
+ * +localpackagediffs page, if true, generate a row of te
+ * +missingpackages page.
*/
var create_row = function(package_name, parent_version, derived_version,
missing_row) {
@@ -77,8 +78,10 @@
extra_row: extra_row
});
- var tests = Y.namespace('lp.registry.distroseriesdifferences_details.test');
- tests.suite = new Y.Test.Suite('lp.registry.distroseriesdifferences_details Tests');
+ var tests = Y.namespace(
+ 'lp.registry.distroseriesdifferences_details.test');
+ tests.suite = new Y.Test.Suite(
+ 'lp.registry.distroseriesdifferences_details Tests');
tests.suite.add(new Y.Test.Case({
name: 'expandable-row-widget',
setUp: function() {
@@ -126,12 +129,15 @@
// First click opens up the new row.
row._toggle.simulate('click');
var new_row = row._row.next();
- Y.Assert.isTrue(row._toggle.hasClass('treeExpanded'), 'is expanded');
+ Y.Assert.isTrue(
+ row._toggle.hasClass('treeExpanded'), 'is expanded');
Y.Assert.isFalse(new_row.hasClass('hidden'), 'not hidden');
- Y.Assert.isTrue(new_row.one('div').hasClass('diff-extra-container'));
+ Y.Assert.isTrue(
+ new_row.one('div').hasClass('diff-extra-container'));
// Second click hides it.
row._toggle.simulate('click');
- Y.Assert.isTrue(row._toggle.hasClass('treeCollapsed'), 'is collapsed');
+ Y.Assert.isTrue(
+ row._toggle.hasClass('treeCollapsed'), 'is collapsed');
Y.Assert.isTrue(new_row.hasClass('hidden'), 'is hidden');
}
}));
@@ -186,8 +192,8 @@
dsdLink: '/a/link',
commentWidget: this.commentWidget
});
- // Set the animation duration to 0.1 to avoid having to wait for its
- // completion for too long.
+ // Set the animation duration to 0.1 to avoid having to wait for
+ // its completion for too long.
this.widget.ANIM_DURATION = 0.1;
},
@@ -233,7 +239,8 @@
var comment_entry = new Comment();
module.lp_client.named_post = function(url, func, config) {
Y.Assert.areEqual(func, method_name);
- Y.ObjectAssert.areEqual(expected_parameters, config.parameters);
+ Y.ObjectAssert.areEqual(
+ expected_parameters, config.parameters);
that.assertIsLocked();
config.on.success(comment_entry);
that.assertIsUnlocked();
@@ -327,7 +334,8 @@
var comment = null;
var target = null;
- var handleEvent = function(e, e_method, e_all, e_comment, e_target) {
+ var handleEvent = function(e, e_method, e_all, e_comment,
+ e_target) {
event_fired = true;
method = e_method;
all = e_all;
@@ -356,7 +364,8 @@
var all = null;
var target = null;
- var handleEvent = function(e, e_method, e_all, e_comment, e_target) {
+ var handleEvent = function(e, e_method, e_all, e_comment,
+ e_target) {
method = e_method;
all = e_all;
target = e_target;
@@ -378,7 +387,8 @@
var all = null;
var target = null;
- var handleEvent = function(e, e_method, e_all, e_comment, e_target) {
+ var handleEvent = function(e, e_method, e_all, e_comment,
+ e_target) {
method = e_method;
all = e_all;
target = e_target;
@@ -391,7 +401,7 @@
Y.Assert.areEqual(input, target);
},
- test_blacklist_submit_handler_blacklist_null_comment_widget: function() {
+ test_blacklist_submit_handler_null_comment_widget: function() {
// The widget can cope with a null commentWidget.
Y.Assert.isNull(this.widget.commentWidget);
var input = Y.one(
@@ -538,7 +548,8 @@
test_initializer: function() {
Y.Assert.areEqual(
- this.latestCommentContainer, this.widget.latestCommentContainer);
+ this.latestCommentContainer,
+ this.widget.latestCommentContainer);
Y.Assert.areEqual(
this.addCommentPlaceholder, this.widget.addCommentPlaceholder);
Y.Assert.areEqual(
@@ -658,7 +669,8 @@
test_clean: function() {
var comment_text = 'Content';
- this.widget.get('srcNode').one('textarea').set('value', comment_text);
+ this.widget.get('srcNode').one('textarea')
+ .set('value', comment_text);
var comment_entry = new Comment();
var post_called = false;
module.lp_client.named_post = function(url, method, config) {
@@ -683,7 +695,8 @@
test_display_new_comment_success: function() {
var that = this;
- var comment_html = '<span id="new_comment">Comment content.</span>';
+ var comment_html =
+ '<span id="new_comment">Comment content.</span>';
var comment_entry = new Comment();
var get_called = false;
module.lp_client.get = function(url, config) {
@@ -709,7 +722,8 @@
},
test_display_new_comment_failure: function() {
- var comment_html = '<span id="new_comment">Comment content.</span>';
+ var comment_html =
+ '<span id="new_comment">Comment content.</span>';
var comment_entry = new Comment();
var get_called = false;
module.lp_client.get = function(url, config) {
@@ -735,7 +749,8 @@
test_add_comment_handler_success: function() {
var comment_text = 'Content';
- this.widget.get('srcNode').one('textarea').set('value', comment_text);
+ this.widget.get('srcNode').one('textarea')
+ .set('value', comment_text);
var comment_entry = new Comment();
var post_called = false;
module.lp_client.named_post = function(url, method, config) {
@@ -762,7 +777,8 @@
test_add_comment_handler_failure: function() {
var comment_text = 'Content';
- this.widget.get('srcNode').one('textarea').set('value', comment_text);
+ this.widget.get('srcNode').one('textarea')
+ .set('value', comment_text);
var post_called = false;
module.lp_client.named_post = function(url, method, config) {
post_called = true;
@@ -779,7 +795,8 @@
test_add_comment_handler_empty: function() {
// An empty comment is treated as a mistake.
var comment_text = '';
- this.widget.get('srcNode').one('textarea').set('value', comment_text);
+ this.widget.get('srcNode').one('textarea')
+ .set('value', comment_text);
var post_called = false;
module.lp_client.named_post = function(url, method, config) {
post_called = true;
@@ -849,8 +866,8 @@
},
test_request_package_diff_computation: function() {
- // A click on the button changes the package diff status and requests
- // the package diffs computation via post.
+ // A click on the button changes the package diff status and
+ // requests the package diffs computation via post.
var placeholder = Y.one('#placeholder');
placeholder
.one('#derived')
@@ -1000,8 +1017,9 @@
},
test_get_packages_summary_missingpackages: function() {
- // get_packages_summary can also parse the row from +missingpackages
- // with no derived_series version of the packages.
+ // get_packages_summary can also parse the row from
+ // +missingpackages with no derived_series version of the
+ // packages.
this.create_rows(true);
Y.one('#placeholder').all('input').set('checked', true);
module.MAX_PACKAGES = 1;
@@ -1016,7 +1034,8 @@
}
}));
}, '0.1', {
- requires: ['test', 'lp.testing.helpers', 'lp.testing.mockio', 'test-console',
+ requires: [
+ 'test', 'lp.testing.helpers', 'lp.testing.mockio', 'test-console',
'lp.registry.distroseriesdifferences_details', 'node-event-simulate',
'lp.soyuz.base', 'lp.anim', 'lp.ui.formoverlay', 'lp.ui.effects',
'lp.soyuz.dynamic_dom_updater', 'event-simulate', 'io-base']
=== modified file 'lib/lp/services/webhooks/javascript/deliveries.js'
--- lib/lp/services/webhooks/javascript/deliveries.js 2017-07-21 17:35:14 +0000
+++ lib/lp/services/webhooks/javascript/deliveries.js 2017-07-24 15:59:04 +0000
@@ -129,7 +129,8 @@
|| date_scheduled < new Date()));
if (retrying_now) {
// Retrying already, or we're currently requesting one.
- detail_node.one(".delivery-retry-notice").addClass("hidden");
+ detail_node.one(".delivery-retry-notice")
+ .addClass("hidden");
detail_node.one(".delivery-retry").addClass("hidden");
detail_node.one(".delivery-delivering-notice")
.removeClass("hidden");
@@ -137,17 +138,23 @@
// Retry scheduled for the future.
var retrying_text =
Y.lp.app.date.approximatedate(date_scheduled);
- detail_node.one(".delivery-retry-notice").set(
- "text", "Retrying " + retrying_text + ".");
- detail_node.one(".delivery-retry").set("text", "Retry now");
- detail_node.one(".delivery-retry-notice").removeClass("hidden");
+ detail_node.one(".delivery-retry-notice")
+ .set("text", "Retrying " + retrying_text + ".");
+ detail_node.one(".delivery-retry")
+ .set("text", "Retry now");
+ detail_node.one(".delivery-retry-notice")
+ .removeClass("hidden");
detail_node.one(".delivery-retry").removeClass("hidden");
- detail_node.one(".delivery-delivering-notice").addClass("hidden");
+ detail_node.one(".delivery-delivering-notice")
+ .addClass("hidden");
} else {
- var retry_text = resource.successful ? "Redeliver" : "Retry";
+ var retry_text =
+ resource.successful ? "Redeliver" : "Retry";
detail_node.one(".delivery-retry").set("text", retry_text);
- detail_node.one(".delivery-retry-notice").addClass("hidden");
- detail_node.one(".delivery-delivering-notice").addClass("hidden");
+ detail_node.one(".delivery-retry-notice")
+ .addClass("hidden");
+ detail_node.one(".delivery-delivering-notice")
+ .addClass("hidden");
detail_node.one(".delivery-retry").removeClass("hidden");
}
}
=== modified file 'lib/lp/soyuz/javascript/tests/test_archivesubscribers_index.js'
--- lib/lp/soyuz/javascript/tests/test_archivesubscribers_index.js 2013-03-20 03:41:40 +0000
+++ lib/lp/soyuz/javascript/tests/test_archivesubscribers_index.js 2017-07-24 15:59:04 +0000
@@ -50,7 +50,8 @@
// The add subscriber row is displayed when the JS is not run.
Assert.areEqual(
'table-row', this.add_subscriber_row.getStyle('display'),
- 'The add subscriber row should display when the js is not run.');
+ 'The add subscriber row should display when the js is not ' +
+ 'run.');
},
test_subscribers_displayed_by_default: function() {
@@ -62,7 +63,8 @@
test_add_row_hidden_after_setup: function() {
// The add subscriber row is hidden during setup.
- Y.lp.soyuz.archivesubscribers_index.setup_archivesubscribers_index();
+ Y.lp.soyuz.archivesubscribers_index
+ .setup_archivesubscribers_index();
Assert.areEqual(
'none', this.add_subscriber_row.getStyle('display'),
'The add subscriber row should be hidden during setup.');
@@ -70,7 +72,8 @@
test_subscribers_section_displayed_after_setup: function() {
// The subscribers div normally remains displayed after setup.
- Y.lp.soyuz.archivesubscribers_index.setup_archivesubscribers_index();
+ Y.lp.soyuz.archivesubscribers_index
+ .setup_archivesubscribers_index();
Assert.areEqual(
'block', this.subscribers_div.getStyle('display'),
'The subscribers div should remain displayed after setup.');
@@ -81,7 +84,8 @@
// Add a paragraph with the no-subscribers id.
this.error_div.set('innerHTML', '<p id="no-subscribers">blah</p>');
- Y.lp.soyuz.archivesubscribers_index.setup_archivesubscribers_index();
+ Y.lp.soyuz.archivesubscribers_index
+ .setup_archivesubscribers_index();
Assert.areEqual(
'none', this.subscribers_div.getStyle('display'),
'The subscribers div should be hidden when there are ' +
@@ -93,8 +97,10 @@
// errors.
// Add an error paragraph.
- this.error_div.set('innerHTML', '<p class="error message">Blah</p>');
- Y.lp.soyuz.archivesubscribers_index.setup_archivesubscribers_index();
+ this.error_div.set(
+ 'innerHTML', '<p class="error message">Blah</p>');
+ Y.lp.soyuz.archivesubscribers_index
+ .setup_archivesubscribers_index();
Assert.areEqual(
'table-row', this.add_subscriber_row.getStyle('display'),
'The add subscriber row should not be hidden if there are ' +
@@ -104,7 +110,8 @@
test_add_access_link_added_after_setup: function() {
// The 'Add access' link is created during setup.
- Y.lp.soyuz.archivesubscribers_index.setup_archivesubscribers_index();
+ Y.lp.soyuz.archivesubscribers_index
+ .setup_archivesubscribers_index();
Assert.areEqual(
'<a class="js-action sprite add" href="#">Add access</a>',
this.add_subscriber_placeholder.get('innerHTML'),
@@ -113,7 +120,8 @@
test_click_add_access_displays_add_row: function() {
// The add subscriber row is displayed after clicking 'Add access'.
- Y.lp.soyuz.archivesubscribers_index.setup_archivesubscribers_index();
+ Y.lp.soyuz.archivesubscribers_index
+ .setup_archivesubscribers_index();
var link_node = this.add_subscriber_placeholder.one('a');
Assert.areEqual(
'Add access', link_node.get('innerHTML'));
=== modified file 'lib/lp/soyuz/javascript/tests/test_dynamic_dom_updater.js'
--- lib/lp/soyuz/javascript/tests/test_dynamic_dom_updater.js 2013-03-20 03:41:40 +0000
+++ lib/lp/soyuz/javascript/tests/test_dynamic_dom_updater.js 2017-07-24 15:59:04 +0000
@@ -210,8 +210,8 @@
// its initialization.
this.wait(function() {
- // Ensure the current actual polling time is more than double the
- // requested interval.
+ // Ensure the current actual polling time is more than
+ // double the requested interval.
var actual_interval = this.config.interval * 4;
this.eg_div.updater._actual_interval = actual_interval;
var updated = this.eg_div.updater._updateActualInterval(
@@ -220,7 +220,8 @@
// The actual interval is updated.
Assert.isTrue(
updated,
- "Poll interval changed if request is faster than expected.");
+ "Poll interval changed if request is faster than " +
+ "expected.");
// The actual interval is changed.
Assert.areEqual(
@@ -247,8 +248,8 @@
// Update the configuration interval:
this.eg_div.updater.set('interval', interval);
- // Ensure the current actual polling time is less than double the
- // requested interval.
+ // Ensure the current actual polling time is less than
+ // double the requested interval.
this.eg_div.updater._actual_interval = (interval * 2) - 2;
var updated = this.eg_div.updater._updateActualInterval(
this.config.short_processing_time - 1);
@@ -256,7 +257,8 @@
// The actual interval is updated.
Assert.isTrue(
updated,
- "Poll interval changed if request is faster than expected.");
+ "Poll interval changed if request is faster than " +
+ "expected.");
// The actual interval is not smaller than the configuration
// interval.
=== modified file 'lib/lp/translations/javascript/tests/test_poexport.js'
--- lib/lp/translations/javascript/tests/test_poexport.js 2017-07-21 17:35:14 +0000
+++ lib/lp/translations/javascript/tests/test_poexport.js 2017-07-24 15:59:04 +0000
@@ -21,7 +21,7 @@
Y.one("#fixture").empty();
},
- test_initialize_pofile_export_page_without_pochanged: function() {
+ test_initialize_pofile_export_without_pochanged: function() {
// The change handler was not added if the checbox does not exist.
var pochanged = Y.one('#div_pochanged');
pochanged.get('parentNode').removeChild(pochanged);
@@ -29,7 +29,7 @@
Y.Assert.isFalse(handler_added);
},
- test_initialize_pofile_export_page_with_pochanged_default_po: function() {
+ test_initialize_pofile_export_with_pochanged_default_po: function() {
// The checkbox is enabled when PO is selected.
var handler_added = namespace.initialize_pofile_export_page();
Y.Assert.isTrue(handler_added);
@@ -41,7 +41,7 @@
Y.one('#div_pochanged input').get('disabled'));
},
- test_initialize_pofile_export_page_with_pochanged_mo_selected: function() {
+ test_initialize_pofile_export_with_pochanged_mo_selected: function() {
// The checkbox is disabled when MO is selected.
var handler_added = namespace.initialize_pofile_export_page();
Y.Assert.isTrue(handler_added);
@@ -57,6 +57,6 @@
}, '0.1', {
- requires: ['lp.testing.runner', 'test', 'test-console', 'node-event-simulate',
- 'lp.translations.poexport']
+ requires: ['lp.testing.runner', 'test', 'test-console',
+ 'node-event-simulate', 'lp.translations.poexport']
});
Follow ups
