launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/simplify-mime-tests into lp:launchpad.

Commit message:
Drop duplicate customizeMimetypes call from lp.services.tests.test_mime; this is done in test setup nowadays.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/simplify-mime-tests/+merge/330156
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/simplify-mime-tests into lp:launchpad.

=== modified file 'lib/lp/services/tests/test_mime.py'
--- lib/lp/services/tests/test_mime.py	2011-08-12 11:37:08 +0000
+++ lib/lp/services/tests/test_mime.py	2017-09-04 12:15:16 +0000
@@ -7,14 +7,8 @@
 
 import mimetypes
 
-from lp.services.mime import customizeMimetypes
 from lp.testing import TestCase
 
-# In our run-time environment this call is made via the initialization section
-# of buildout.cfg but that initialization is not done for tests so it must be
-# done manually here.
-customizeMimetypes()
-
 
 class TestBzip(TestCase):
     """Tests for iter_split."""