launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/fix-memcache-error-message into lp:launchpad.

Commit message:
Fix memcache_client_factory error case.  config.memcache.addresses isn't a thing.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/fix-memcache-error-message/+merge/331417
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/fix-memcache-error-message into lp:launchpad.

=== modified file 'lib/lp/services/memcache/client.py'
--- lib/lp/services/memcache/client.py	2012-01-01 02:58:52 +0000
+++ lib/lp/services/memcache/client.py	2017-09-27 11:21:23 +0000
@@ -1,4 +1,4 @@
-# Copyright 2009 Canonical Ltd.  This software is licensed under the
+# Copyright 2009-2017 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 """Launchpad Memcache client."""
@@ -23,7 +23,7 @@
         (host, int(weight)) for host, weight in re.findall(
             r'\((.+?),(\d+)\)', config.memcache.servers)]
     assert len(servers) > 0, "Invalid memcached server list %r" % (
-        config.memcache.addresses,)
+        config.memcache.servers,)
     return TimelineRecordingClient(servers)