launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/meta-lp-deps/frontend-dependencies into lp:meta-lp-deps.

Commit message:
'Add a new launchpad-frontend-dependencies metapackage, currently
equivalent to launchpad-dependencies plus nodejs; this should be
sufficient to run "make build", which builds Launchpad's JavaScript code
as well as its Python code.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/meta-lp-deps/frontend-dependencies/+merge/331760

I previously added nodejs to launchpad-developer-dependencies in what I thought at the time was obvious support of https://code.launchpad.net/~cjwatson/launchpad/yarn/+merge/327823, but immediately afterwards I realised that that's not quite right, because we need it on the frontend machines too so that they can run "make build".  I don't want to add it to all Launchpad hosts when most of them don't need it.  This seems like a reasonable compromise: we'll have to get IS to install the new launchpad-frontend-dependencies package on our frontends, but that's easy enough.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/meta-lp-deps/frontend-dependencies into lp:meta-lp-deps.

=== modified file 'debian/changelog'
--- debian/changelog	2017-10-01 14:25:53 +0000
+++ debian/changelog	2017-10-04 01:32:49 +0000
@@ -1,3 +1,12 @@
+launchpad-dependencies (0.132) UNRELEASED; urgency=medium
+
+  * Add a new launchpad-frontend-dependencies metapackage, currently
+    equivalent to launchpad-dependencies plus nodejs; this should be
+    sufficient to run "make build", which builds Launchpad's JavaScript code
+    as well as its Python code.
+
+ -- Colin Watson <cjwatson@xxxxxxxxxx>  Wed, 04 Oct 2017 02:24:29 +0100
+
 launchpad-dependencies (0.131) xenial; urgency=medium
 
   * Add gnupg to launchpad-dependencies, just in case it's dropped from

=== modified file 'debian/control'
--- debian/control	2017-10-01 14:05:00 +0000
+++ debian/control	2017-10-04 01:32:49 +0000
@@ -47,6 +47,7 @@
   launchpad-database-dependencies (= ${source:Version}),
   launchpad-messagequeue-dependencies (= ${source:Version}),
   launchpad-soyuz-dependencies (= ${source:Version}),
+  launchpad-frontend-dependencies (= ${source:Version}),
   exuberant-ctags, bzr-pqm, geoip-data-city-lite,
   pgbouncer (>= 1.6) | pgbouncer-with-disconnect, postgresql-autodoc, tidy,
   python-codespeak-lib | python-py,
@@ -55,7 +56,6 @@
   xvfb, firefox, intltool, python-pocket-lint,
   python-lpbuildd (>= 88),
   python-html5-browser,
-  nodejs,
   ${misc:Depends}
 Recommends: pyflakes, subunit, python-boto, bzr-lpreview-body,
   postgresql-doc-9.3
@@ -118,3 +118,12 @@
 Description: Metapackage for Launchpad messagequeue packages
  This metapackage depends on all of the packages necessary to run a Launchpad
  messagequeue server.
+
+Package: launchpad-frontend-dependencies
+Architecture: all
+Depends: launchpad-dependencies (= ${source:Version}),
+  nodejs,
+  ${misc:Depends}
+Description: Metapackage for Launchpad frontend dependencies
+ This metapackage depends on all of the packages necessary to run a Launchpad
+ frontend server, including building Launchpad's JavaScript.