launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> 
> === modified file 'lib/lp/code/interfaces/branch.py'
> --- lib/lp/code/interfaces/branch.py	2016-11-11 12:51:58 +0000
> +++ lib/lp/code/interfaces/branch.py	2017-11-06 09:48:10 +0000
> @@ -538,6 +538,10 @@
>      pending_writes = Attribute(
>          "Whether there is new Bazaar data for this branch.")
>  
> +    pending_updates = Attribute(
> +        "Whether there is an update job of some kind (mirroring or scanning) "
> +        "pending for the Bazaar data in this branch.")

Perhaps worth noting that this isn't always true when pending_writes is. A naïve reading would leave one with an erroneous assumption.

> +
>      def latest_revisions(quantity=10):
>          """A specific number of the latest revisions in that branch."""
>  


-- 
https://code.launchpad.net/~cjwatson/launchpad/branch-unscan-affordances/+merge/333251
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.