launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Diff comments:

> 
> === modified file 'utilities/lint'
> --- utilities/lint	2017-01-17 22:23:39 +0000
> +++ utilities/lint	2017-07-23 03:47:01 +0000
> @@ -31,10 +31,21 @@
>  fi
>  
>  # Sample data contains auto generated files with long lines.
> -pocketlint_files=`echo "$files" | env -i grep -v ".sql$"`
> +pocketlint_files=`echo "$files" | env -i grep -v '\.sql$'`
>  if [ -z "$pocketlint_files" ]; then
>      exit 0
>  fi
> -
> -echo ""
> -pocketlint $pocketlint_files 2>&1
> +pocketlint_files=`echo "$pocketlint_files" | tr " " "\n"`
> +
> +non_js_files=`echo "$pocketlint_files" | env -i grep -v '\.js$'`
> +js_files=`echo "$pocketlint_files" | env -i grep '\.js$'`
> +
> +ret=0
> +if [ "$non_js_files" ]; then
> +    echo ""
> +    pocketlint $non_js_files 2>&1 || ret=$?
> +fi
> +if [ "$js_files" ]; then
> +    nodejs node_modules/.bin/eslint $js_files 2>&1 || ret=$?

eslint does that by itself if it has anything to say.  I've added a comment to that effect.

> +fi
> +exit $ret


-- 
https://code.launchpad.net/~cjwatson/launchpad/eslint/+merge/327884
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.