launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> === modified file 'Makefile'
> --- Makefile	2018-01-01 20:24:26 +0000
> +++ Makefile	2018-01-02 04:49:50 +0000
> @@ -472,6 +468,7 @@
>  		-e 's,%LISTEN_ADDRESS%,$(LISTEN_ADDRESS),' \
>  		configs/development/local-launchpad-apache > \
>  		/etc/apache2/sites-available/$$base
> +	mkdir -p $(CODEHOSTING_ROOT)

This is *meant* to be arranged by codehosting-dir, though that 777 is pretty sweet. Should we just fix that up to DTRT and dep on it?

>  	touch $(CODEHOSTING_ROOT)/rewrite.log
>  	chown -R $(SUDO_UID):$(SUDO_GID) $(CODEHOSTING_ROOT)
>  	if [ ! -d /srv/launchpad.dev ]; then \


-- 
https://code.launchpad.net/~cjwatson/launchpad/tidy-makefile/+merge/335614
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.