launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> 
> === modified file 'sourcecode/Makefile'
> --- sourcecode/Makefile	2011-11-07 20:29:29 +0000
> +++ sourcecode/Makefile	2017-12-22 10:00:58 +0000
> @@ -3,7 +3,7 @@
>  # the ones we test.  If we fix them all to have EITHER a good makefile
>  # (build and check targets work), or no makefile we can reenable auto
>  # detection.
> -build_dirs:=cscvs dulwich pygettextpo pygpgme subvertpy
> +build_dirs:=cscvs pygettextpo pygpgme subvertpy

Might as well ditch pygpgme and subvertpy while you're here.

>  test_dirs:=cscvs pygettextpo
>  
>  TEST_ENV_VARS = PYTHON=$(PYTHON)


-- 
https://code.launchpad.net/~cjwatson/launchpad/pypi-dulwich/+merge/335539
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.