launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/buildd-manager-feature-controller into lp:launchpad.

Commit message:
Set up a feature controller for buildd-manager.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/buildd-manager-feature-controller/+merge/336018

We can't use feature rules otherwise.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/buildd-manager-feature-controller into lp:launchpad.

=== modified file 'daemons/buildd-manager.tac'
--- daemons/buildd-manager.tac	2016-05-25 15:33:28 +0000
+++ daemons/buildd-manager.tac	2018-01-12 00:12:08 +0000
@@ -1,4 +1,4 @@
-# Copyright 2009-2016 Canonical Ltd.  This software is licensed under the
+# Copyright 2009-2018 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 # Twisted Application Configuration file.
@@ -17,6 +17,7 @@
 from lp.services.scripts import execute_zcml_for_scripts
 from lp.buildmaster.manager import BuilddManager
 from lp.services.mail.sendmail import set_immediate_mail_delivery
+from lp.services.twistedsupport.features import setup_feature_controller
 from lp.services.twistedsupport.loggingsupport import RotatableFileLogObserver
 
 execute_zcml_for_scripts()
@@ -44,3 +45,6 @@
 # Service for scanning buildd slaves.
 service = BuilddManager()
 service.setServiceParent(application)
+
+# Allow use of feature flags.
+setup_feature_controller('buildd-manager')