launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/more-obvious-updating-repository-notice into lp:launchpad.

Commit message:
Move "Updating repository..." notice above the list of branches so that it's harder to miss.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
Related bugs:
  Bug #1745161 in Launchpad itself: ""Updating repository" notice is hidden at the bottom of the page"
  https://bugs.launchpad.net/launchpad/+bug/1745161

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/more-obvious-updating-repository-notice/+merge/336680
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/more-obvious-updating-repository-notice into lp:launchpad.

=== modified file 'lib/lp/code/templates/gitrepository-index.pt'
--- lib/lp/code/templates/gitrepository-index.pt	2017-11-06 09:32:45 +0000
+++ lib/lp/code/templates/gitrepository-index.pt	2018-01-26 13:52:29 +0000
@@ -64,14 +64,6 @@
     </div>
   </div>
 
-  <div class="yui-g">
-    <div id="repository-branches" class="portlet"
-         tal:define="branches view/branches">
-      <h2>Branches</h2>
-      <tal:repository-branches replace="structure branches/@@+ref-listing" />
-    </div>
-  </div>
-
   <div class="yui-g" tal:condition="context/pending_updates">
     <div class="portlet">
       <div id="repository-pending-updates" class="pending-update">
@@ -84,6 +76,14 @@
     </div>
   </div>
 
+  <div class="yui-g">
+    <div id="repository-branches" class="portlet"
+         tal:define="branches view/branches">
+      <h2>Branches</h2>
+      <tal:repository-branches replace="structure branches/@@+ref-listing" />
+    </div>
+  </div>
+
 </div>
 
 </body>