launchpad-reviewers team mailing list archive

[Maximiliano Bertacchini <maximiliano.bertacchini@xxxxxxxxxxxxx>]

Maximiliano Bertacchini has proposed merging lp:~maxiberta/launchpad/lp-1729580-2 into lp:launchpad.

Commit message:
Use target="_blank" in extended snap build error links.

Requested reviews:
  Colin Watson (cjwatson)

For more details, see:
https://code.launchpad.net/~maxiberta/launchpad/lp-1729580-2/+merge/338562

Use target="_blank" in extended snap build error links. Fixes browsers refusing to load external links due to "X-Frame-Options: sameorigin".
-- 
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

=== modified file 'lib/lp/snappy/templates/snapbuild-index.pt'
--- lib/lp/snappy/templates/snapbuild-index.pt	2018-02-19 17:51:30 +0000
+++ lib/lp/snappy/templates/snapbuild-index.pt	2018-02-22 15:53:34 +0000
@@ -185,7 +185,7 @@
               <span tal:replace="error/message"/>
               <a tal:condition="error/link"
                   tal:attributes="href error/link"
-                  target="help"
+                  target="_blank"
                   class="sprite maybe action-icon">(?)</a>
             </li>
           </ul>