launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad-buildd/log-build-url into lp:launchpad-buildd.

Commit message:
If Launchpad passes a build_url item in the extra build arguments, then emit it at the start of the log.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad-buildd/log-build-url/+merge/341126
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad-buildd/log-build-url into lp:launchpad-buildd.

=== modified file 'debian/changelog'
--- debian/changelog	2018-01-15 10:08:55 +0000
+++ debian/changelog	2018-03-08 11:52:46 +0000
@@ -1,3 +1,10 @@
+launchpad-buildd (159) UNRELEASED; urgency=medium
+
+  * If Launchpad passes a build_url item in the extra build arguments, then
+    emit it at the start of the log.
+
+ -- Colin Watson <cjwatson@xxxxxxxxxx>  Thu, 08 Mar 2018 11:28:40 +0000
+
 launchpad-buildd (158) xenial; urgency=medium
 
   [ Steve Langasek ]

=== modified file 'lpbuildd/slave.py'
--- lpbuildd/slave.py	2017-10-27 08:08:49 +0000
+++ lpbuildd/slave.py	2018-03-08 11:52:46 +0000
@@ -225,6 +225,9 @@
         value keyed under the 'archive_private' string. If that value
         evaluates to True the build at hand is for a private archive.
         """
+        if 'build_url' in extra_args:
+            self._slave.log("%s\n" % extra_args['build_url'])
+
         os.mkdir("%s/build-%s" % (self.home, self._buildid))
         for f in files:
             os.symlink( self._slave.cachePath(files[f]),