launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> 
> === modified file 'lib/lp/snappy/templates/snap-index.pt'
> --- lib/lp/snappy/templates/snap-index.pt	2017-01-04 20:52:12 +0000
> +++ lib/lp/snappy/templates/snap-index.pt	2018-04-20 19:38:01 +0000
> @@ -61,6 +61,19 @@
>            <a tal:replace="structure view/menu:overview/edit/fmt:icon"/>
>          </dd>
>        </dl>
> +      <dl id="source_tarball"
> +          tal:define="source_tarball context/source_tarball">
> +        <dt>Source tarball:</dt>
> +        <dd>
> +          <span tal:condition="source_tarball">
> +            Builds of this snap package will also build a source tarball.
> +          </span>
> +          <span tal:condition="not: source_tarball">
> +            Builds of this snap package will not build a source tarball.
> +          </span>

This is really slow to parse. Build source tarball: Yes/No?

> +          <a tal:replace="structure view/menu:overview/edit/fmt:icon"/>
> +        </dd>
> +      </dl>
>  
>        <dl id="auto_build">
>          <dt>Build schedule:


-- 
https://code.launchpad.net/~cjwatson/launchpad/snap-source-tarball/+merge/343727
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.