launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> 
> === modified file 'lib/lp/registry/interfaces/person.py'
> --- lib/lp/registry/interfaces/person.py	2018-04-17 00:26:25 +0000
> +++ lib/lp/registry/interfaces/person.py	2018-04-23 08:41:01 +0000
> @@ -569,6 +572,24 @@
>          required=False, default=False)
>  
>  
> +class IPersonSettingsModerate(Interface):
> +    """Settings for a person (not a team!) that are used relatively rarely.
> +
> +    These attributes need launchpad.View to see, and launchpad.Moderate to
> +    change.
> +    """
> +
> +    require_strong_email_authentication = Bool(
> +        title=_("Require strong authentication for incoming emails"),
> +        description=_(
> +            "If this option is set, Launchpad will only accept incoming "
> +            "emails from you if it can authenticate them using GPG or DKIM.  "

s/GPG/OpenPGP/?

> +            "Launchpad administrators may set this if one of your email "
> +            "addresses is being forged as the sender address for incoming "
> +            "spam."),
> +        required=False, default=False)
> +
> +
>  class IPersonPublic(IPrivacy):
>      """Public attributes for a Person.
>  


-- 
https://code.launchpad.net/~cjwatson/launchpad/email-force-strong-auth/+merge/343790
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.