launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/close-account-git-subscription into lp:launchpad.

Commit message:
Remove Git subscriptions in close-account.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/close-account-git-subscription/+merge/345237
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/close-account-git-subscription into lp:launchpad.

=== modified file 'scripts/close-account.py'
--- scripts/close-account.py	2011-12-30 06:47:17 +0000
+++ scripts/close-account.py	2018-05-08 14:13:52 +0000
@@ -121,11 +121,11 @@
 
     # Remove rows from tables in simple cases in the given order
     removals = [
-        # Trash their email addresses. Unsociable privacy nut jobs who request
-        # account removal would be pissed if they reregistered with their old
-        # email address and this resurrected their deleted account, as the
-        # email address is probably the piece of data we store that they where
-        # most concerned with being removed from our systems.
+        # Trash their email addresses. People who request complete account
+        # removal would be unhappy if they reregistered with their old email
+        # address and this resurrected their deleted account, as the email
+        # address is probably the piece of data we store that they were most
+        # concerned with being removed from our systems.
         ('EmailAddress', 'person'),
 
         # Trash their codes of conduct and GPG keys
@@ -134,6 +134,7 @@
 
         # Subscriptions
         ('BranchSubscription', 'person'),
+        ('GitSubscription', 'person'),
         ('BugSubscription', 'person'),
         ('QuestionSubscription', 'person'),
         ('SpecificationSubscription', 'person'),