launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> 
> === modified file 'lib/launchpad_loggerhead/tests.py'
> --- lib/launchpad_loggerhead/tests.py	2018-01-19 17:21:44 +0000
> +++ lib/launchpad_loggerhead/tests.py	2018-06-04 14:37:09 +0000
> @@ -1,29 +1,44 @@
>  # Copyright 2010-2018 Canonical Ltd.  This software is licensed under the
>  # GNU Affero General Public License version 3 (see the file LICENSE).
>  
> -import urllib
> -
>  import lazr.uri
>  from paste.httpexceptions import HTTPExceptionHandler
> +import requests
> +from six.moves.urllib_parse import (
> +    urlencode,
> +    urlsplit,
> +    )
> +import soupmatchers
> +from testtools.content import Content
> +from testtools.content_type import UTF8_TEXT
>  import wsgi_intercept
>  from wsgi_intercept.urllib2_intercept import (
>      install_opener,
>      uninstall_opener,
>      )
>  import wsgi_intercept.zope_testbrowser
> +from zope.security.proxy import removeSecurityProxy
>  
>  from launchpad_loggerhead.app import RootApp
>  from launchpad_loggerhead.session import SessionHandler
> +from launchpad_loggerhead.testing import LoggerheadFixture
> +from lp.app.enums import InformationType
>  from lp.services.config import config
>  from lp.services.webapp.vhosts import allvhosts
> -from lp.testing import TestCase
> -from lp.testing.layers import DatabaseFunctionalLayer
> +from lp.testing import (
> +    TestCase,
> +    TestCaseWithFactory,
> +    )
> +from lp.testing.layers import (
> +    AppServerLayer,
> +    DatabaseFunctionalLayer,
> +    )
>  
>  
>  SESSION_VAR = 'lh.session'
>  
> -# See sourcecode/launchpad-loggerhead/start-loggerhead.py for the production
> -# mechanism for getting the secret.
> +# See lib/launchpad-loggerhead/wsgi.py for the production mechanism for

s/-/_/

> +# getting the secret.
>  SECRET = 'secret'
>  
>  


-- 
https://code.launchpad.net/~cjwatson/launchpad/loggerhead-gunicorn/+merge/347387
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.