launchpad-reviewers team mailing list archive

[Maximiliano Bertacchini <maximiliano.bertacchini@xxxxxxxxxxxxx>]

The proposal to merge lp:~maxiberta/launchpad/sshkeyadditionerror-msg-format into lp:launchpad has been updated.

Description changed to:

Fix encoding crash while adding an ssh key with unknown type. E.g. on an attempt to add this key in SSO /ssh-keys:

    ssh-rsa asdfasdf comment

LP raises an encoding error and crashes. See https://sentry.ols.canonical.com/canonical/sso/issues/669/.

Also, add a warning to try to prevent a mismatch with SSO regex matching.

For more details, see:
https://code.launchpad.net/~maxiberta/launchpad/sshkeyadditionerror-msg-format/+merge/348230
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~maxiberta/launchpad/sshkeyadditionerror-msg-format into lp:launchpad.