launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/no-default-http-proxy into lp:launchpad.

Commit message:
Don't set http_proxy by default.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/no-default-http-proxy/+merge/348540

It's now set in lp-production-configs for deployments on Canonical networks, and anyone else is unlikely to want squid.internal.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/no-default-http-proxy into lp:launchpad.

=== modified file 'lib/lp/services/config/schema-lazr.conf'
--- lib/lp/services/config/schema-lazr.conf	2018-06-06 12:46:56 +0000
+++ lib/lp/services/config/schema-lazr.conf	2018-06-26 15:01:25 +0000
@@ -915,7 +915,7 @@
 # not the Launchpad section? At the moment, there are only scripts
 # using this.
 # datatype: string
-http_proxy: http://squid.internal:3128/
+http_proxy: none
 
 # Session cookies being sent to a subdomain of the parent
 # domains listed here will be sent to the parent domain,