launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/snap-initial-name-bzr-review-fix into lp:launchpad.

Commit message:
Apply minor cleanup to SnapAddView.initial_values spotted in review.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/snap-initial-name-bzr-review-fix/+merge/349243

This is from https://code.launchpad.net/~cjwatson/launchpad/snap-initial-name-bzr/+merge/345757, but I forgot to sort it out before landing that.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/snap-initial-name-bzr-review-fix into lp:launchpad.

=== modified file 'lib/lp/snappy/browser/snap.py'
--- lib/lp/snappy/browser/snap.py	2018-05-16 23:35:33 +0000
+++ lib/lp/snappy/browser/snap.py	2018-07-10 08:33:03 +0000
@@ -431,10 +431,7 @@
                     CannotParseSnapcraftYaml):
                 pass
             else:
-                try:
-                    store_name = snapcraft_data.get('name')
-                except AttributeError:
-                    pass
+                store_name = snapcraft_data.get('name')
 
         store_series = getUtility(ISnappySeriesSet).getAll().first()
         if store_series.preferred_distro_series is not None: