launchpad-reviewers team mailing list archive
-
launchpad-reviewers team
-
Mailing list archive
-
Message #22755
[Merge] lp:~cjwatson/launchpad/traversal-no-class-advice into lp:launchpad
The proposal to merge lp:~cjwatson/launchpad/traversal-no-class-advice into lp:launchpad has been updated.
Description changed to:
Zope class advice doesn't work in Python 3, and decorators seem somewhat more Pythonic anyway. We just need to store the information in method attributes rather than class attributes.
I considered retaining the two-argument form of redirection as a class decorator, but rewriting the call sites was trivial enough that it wasn't worth it.
For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/traversal-no-class-advice/+merge/349625
--
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/traversal-no-class-advice into lp:launchpad.
References