launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Colin Watson has proposed merging lp:~cjwatson/launchpad/feedparser-5.2.1 into lp:launchpad.

Commit message:
Upgrade to feedparser 5.2.1.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/feedparser-5.2.1/+merge/349639

This adds Python 3 support.  I also want this because the previous version monkey-patched sgmllib, which caused weird problems with BeautifulSoup in some cases; this version no longer does that.

Launchpad only uses feedparser to get the latest entries from blog.launchpad.net for the front page, and I've verified that the results of doing that are identical with the old and new versions.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of lp:~cjwatson/launchpad/feedparser-5.2.1 into lp:launchpad.

=== modified file 'constraints.txt'
--- constraints.txt	2018-07-10 09:05:45 +0000
+++ constraints.txt	2018-07-16 11:13:23 +0000
@@ -253,7 +253,7 @@
 enum34==1.1.6
 epydoc==3.0.1
 extras==1.0.0
-feedparser==4.1
+feedparser==5.2.1
 feedvalidator==0.0.0DEV-r1049
 fixtures==3.0.0
 FormEncode==1.2.4

=== modified file 'setup.py'
--- setup.py	2018-07-01 21:56:44 +0000
+++ setup.py	2018-07-16 11:13:23 +0000
@@ -156,7 +156,7 @@
         # Required for dkimpy
         'dnspython',
         'dulwich',
-        'FeedParser',
+        'feedparser',
         'feedvalidator',
         'fixtures',
         'gunicorn[gthread]',