launchpad-reviewers team mailing list archive

[William Grant <me@xxxxxxxxxxxxxxxxxx>]

Review: Approve code



Diff comments:

> 
> === modified file 'lib/lp/soyuz/interfaces/archive.py'
> --- lib/lp/soyuz/interfaces/archive.py	2018-06-27 00:27:02 +0000
> +++ lib/lp/soyuz/interfaces/archive.py	2018-07-22 20:52:48 +0000
> @@ -462,7 +462,18 @@
>      series_with_sources = Attribute(
>          "DistroSeries to which this archive has published sources")
>      signing_key = Object(
> -        title=_('Repository sigining key.'), required=False, schema=IGPGKey)
> +        title=_('Repository signing key.'), required=False, schema=IGPGKey)
> +
> +    @export_read_operation()
> +    @operation_for_version("devel")
> +    def getSigningKeyData():
> +        """Get the public key used to sign this repository.
> +
> +        Returns the public key material as a byte string, None if the
> +        repository has no signing key, or an HTTP status code if the
> +        repository has a signing key but it cannot be retrieved from the
> +        keyserver.
> +        """

It seems like the whole request can 404 or 500 depending on what the server says, but I wouldn't describe that as "return[ing] [...] an HTTP status code" in the same sense as a bytestring or None.

>  
>      def getAuthToken(person):
>          """Returns an IArchiveAuthToken for the archive in question for


-- 
https://code.launchpad.net/~cjwatson/launchpad/archive-get-signing-key-data/+merge/350431
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.