launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Review: Approve



Diff comments:

> 
> === modified file 'lib/lp/code/templates/gitlisting.pt'
> --- lib/lp/code/templates/gitlisting.pt	2018-08-22 14:04:22 +0000
> +++ lib/lp/code/templates/gitlisting.pt	2018-08-29 14:31:12 +0000
> @@ -55,6 +55,16 @@
>      <span class="see-all" tal:condition="view/show_bzr_link">
>        <a tal:attributes="href context/fmt:url:code/+branches">View Bazaar branches</a>
>      </span>
> +
> +    <p id="personal-git-directions" tal:condition="view/show_personal_directions">
> +      You can create new personal repositories by pushing an existing git repository
> +      to launchpad with the following commands:
> +      <br />
> +      <tt class="command">git remote add origin git+ssh://<tal:name replace="view/user/name"/>@git.launchpad.net/~<tal:name replace="view/user/name"/>/+git/<em>REPOSITORY_NAME</em></tt>
> +      <br />
> +      <tt class="command">git push --set-upstream origin master</tt>

We use <pre class="command"> for multi-line things elsewhere (e.g. lib/lp/soyuz/templates/archive-index.pt); could you do that here too?  That would also allow you to tighten the CSS rule to "pre#personal-git-directions", I think (or maybe that's "p#personal-git-directions pre" or something), which would be better.

> +    </p>
> +
>      <tal:default-repository
>          condition="view/default_git_repository"
>          define="repository view/default_git_repository">


-- 
https://code.launchpad.net/~twom/launchpad/git-instructions-for-people/+merge/353971
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.