launchpad-reviewers team mailing list archive

[Colin Watson <cjwatson@xxxxxxxxxxxxx>]

Diff comments:

> 
> === modified file 'lib/lp/code/model/gitrepository.py'
> --- lib/lp/code/model/gitrepository.py	2018-07-24 11:57:33 +0000
> +++ lib/lp/code/model/gitrepository.py	2018-08-29 16:40:53 +0000
> @@ -942,6 +942,21 @@
>              Not(BranchMergeProposal.queue_status.is_in(
>                  BRANCH_MERGE_PROPOSAL_FINAL_STATES)))
>  
> +    def getMergeProposals(self, status=None, visible_by_user=None,
> +                          merged_revision_ids=None, eager_load=False):
> +        """See `IGitRef`."""

IGitRepository again.

> +        if not status:
> +            status = (
> +                BranchMergeProposalStatus.CODE_APPROVED,
> +                BranchMergeProposalStatus.NEEDS_REVIEW,
> +                BranchMergeProposalStatus.WORK_IN_PROGRESS)
> +
> +        collection = getUtility(IAllGitRepositories).visibleByUser(
> +            visible_by_user)
> +        return collection.getMergeProposals(
> +            status, target_repository=self,
> +            merged_revision_ids=merged_revision_ids, eager_load=eager_load)
> +
>      def getMergeProposalByID(self, id):
>          """See `IGitRepository`."""
>          return self.landing_targets.find(BranchMergeProposal.id == id).one()


-- 
https://code.launchpad.net/~twom/launchpad/git-active-review-on-more-git-repo/+merge/353884
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.